next/font: Generate fallback fonts #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: * Generates and uses definitions for fallback system fonts to use in place of user fonts, or as they are loading. * Reads the font metrics file from the `next` package directly relative to the user's app. * Fixes a bug where `adjust_font_fallback` defaulted to `false` instead of `true`. * Begins to refactor next/font code to be more modular in anticipation of `next/font/local` support. * Changes `handle_resolve_error` to take an origin `FileSystemPathVc` instead of a `ResolveOriginVc` as this is all it used, and a resolve origin isn't always available.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 93bc930
Click to view full benchmark
|
jridgewell
reviewed
Mar 6, 2023
Benchmark for c2a58ee
Click to view full benchmark
|
jridgewell
reviewed
Mar 7, 2023
Benchmark for a6544fb
Click to view full benchmark
|
Benchmark for 848c489
Click to view full benchmark
|
jridgewell
approved these changes
Mar 7, 2023
wbinnssmith
added a commit
that referenced
this pull request
Mar 7, 2023
This removes the duplicated (and possibly mismatching) font data file in favor of loading the copy bundled with next, using `load_next_json` introduced in #4086. It also removes the associated workflow and generation script.
mehulkar
pushed a commit
that referenced
this pull request
Mar 7, 2023
This: * Generates and uses definitions for fallback system fonts to use in place of user fonts, or as they are loading. * Reads the font metrics file from the `next` package directly relative to the user's app. * Fixes a bug where `adjust_font_fallback` defaulted to `false` instead of `true`. * Begins to refactor next/font code to be more modular in anticipation of `next/font/local` support. * Changes `handle_resolve_error` to take an origin `FileSystemPathVc` instead of a `ResolveOriginVc` as this is all it used, and a resolve origin isn't always available.
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 8, 2023
## Bugfixes - vercel/turbo#3526 - vercel/turbo#4084 - vercel/turbo#4083 - vercel/turbo#4067 - vercel/turbo#3959 - vercel/turbo#4060 - vercel/turbo#4081 - vercel/turbo#4103 - vercel/turbo#4100 - vercel/turbo#4108 - vercel/turbo#4101 - vercel/turbo#4112 - vercel/turbo#3956 - vercel/turbo#4118 - vercel/turbo#4117 ## Feature - vercel/turbo#4058 - vercel/turbo#4013 - vercel/turbo#4005 - vercel/turbo#4001 - vercel/turbo#3839 - vercel/turbo#4017 - vercel/turbo#4086 - vercel/turbo#4067 ## Performance - vercel/turbo#4040 - vercel/turbo#4110 ## Refactor - vercel/turbo#4098
wbinnssmith
added a commit
that referenced
this pull request
Mar 8, 2023
This removes the duplicated (and possibly mismatching) font data file in favor of loading the copy bundled with next, using `load_next_json` introduced in #4086. It also removes the associated workflow and generation script.
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This: * Generates and uses definitions for fallback system fonts to use in place of user fonts, or as they are loading. * Reads the font metrics file from the `next` package directly relative to the user's app. * Fixes a bug where `adjust_font_fallback` defaulted to `false` instead of `true`. * Begins to refactor next/font code to be more modular in anticipation of `next/font/local` support. * Changes `handle_resolve_error` to take an origin `FileSystemPathVc` instead of a `ResolveOriginVc` as this is all it used, and a resolve origin isn't always available.
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…turbo#4111) This removes the duplicated (and possibly mismatching) font data file in favor of loading the copy bundled with next, using `load_next_json` introduced in vercel/turbo#4086. It also removes the associated workflow and generation script.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This: * Generates and uses definitions for fallback system fonts to use in place of user fonts, or as they are loading. * Reads the font metrics file from the `next` package directly relative to the user's app. * Fixes a bug where `adjust_font_fallback` defaulted to `false` instead of `true`. * Begins to refactor next/font code to be more modular in anticipation of `next/font/local` support. * Changes `handle_resolve_error` to take an origin `FileSystemPathVc` instead of a `ResolveOriginVc` as this is all it used, and a resolve origin isn't always available.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…turbo#4111) This removes the duplicated (and possibly mismatching) font data file in favor of loading the copy bundled with next, using `load_next_json` introduced in vercel/turbo#4086. It also removes the associated workflow and generation script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
nextpackage directly relative to the user's app.adjust_font_fallbackdefaulted tofalseinstead oftrue.next/font/localsupport.handle_resolve_errorto take an originFileSystemPathVcinstead of aResolveOriginVcas this is all it used, and a resolve origin isn't always available.