Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEB-415: next/font/google: Use next's bundled font-data.json #4111

Merged
merged 1 commit into from Mar 8, 2023
Merged

WEB-415: next/font/google: Use next's bundled font-data.json #4111

merged 1 commit into from Mar 8, 2023

Conversation

wbinnssmith
Copy link
Member

This removes the duplicated (and possibly mismatching) font data file in favor of loading the copy bundled with next, using load_next_json introduced in #4086. It also removes the associated workflow and generation script.

@wbinnssmith
next/font/google: Use next's bundled font-data.json
57986dd 
This removes the duplicated (and possibly mismatching) font data file in favor of loading the copy bundled with next, using `load_next_json` introduced in #4086. It also removes the associated workflow and generation script.
@wbinnssmith wbinnssmith requested review from a team as code owners March 7, 2023 20:41
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 8:42PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 7, 2023 at 8:42PM (UTC)

@mehulkar mehulkar removed their request for review March 7, 2023 21:01
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023 •
edited

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Benchmark for 829907a

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 2069.17ms ± 2.26ms 2058.42ms ± 2.50ms -0.52% -0.06%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9441.12µs ± 52.20µs 9483.10µs ± 47.85µs +0.44%
bench_hmr_to_commit/Turbopack RCC/1000 modules 11.72ms ± 0.08ms 11.81ms ± 0.08ms +0.72%
bench_hmr_to_commit/Turbopack RSC/1000 modules 515.60ms ± 1.17ms 513.29ms ± 0.93ms -0.45%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9719.14µs ± 33.31µs 9752.33µs ± 63.07µs +0.34%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8371.86µs ± 39.40µs 8331.67µs ± 59.41µs -0.48%
bench_hmr_to_eval/Turbopack RCC/1000 modules 10.63ms ± 0.04ms 10.70ms ± 0.06ms +0.62%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8636.00µs ± 39.22µs 8689.05µs ± 52.74µs +0.61%
bench_hydration/Turbopack RCC/1000 modules 3650.44ms ± 6.77ms 3672.17ms ± 8.30ms +0.60%
bench_hydration/Turbopack RSC/1000 modules 3260.37ms ± 12.45ms 3269.30ms ± 15.05ms +0.27%
bench_hydration/Turbopack SSR/1000 modules 3383.66ms ± 6.84ms 3395.36ms ± 8.55ms +0.35%
bench_startup/Turbopack CSR/1000 modules 2627.67ms ± 6.43ms 2635.62ms ± 9.89ms +0.30%
bench_startup/Turbopack RCC/1000 modules 2130.95ms ± 5.12ms 2118.84ms ± 3.42ms -0.57%
bench_startup/Turbopack RSC/1000 modules 2058.03ms ± 6.14ms 2046.79ms ± 3.26ms -0.55%
bench_startup/Turbopack SSR/1000 modules 2069.17ms ± 2.26ms 2058.42ms ± 2.50ms -0.52% -0.06%

@wbinnssmith wbinnssmith changed the title next/font/google: Use next's bundled font-data.json WEB-415: next/font/google: Use next's bundled font-data.json Mar 7, 2023
@wbinnssmith wbinnssmith merged commit f97ac29 into main Mar 8, 2023
@wbinnssmith wbinnssmith deleted the wbinnssmith/use-bundled-font-data branch March 8, 2023 16:25
@jridgewell jridgewell mentioned this pull request Mar 8, 2023
Merged
ijjk pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@jridgewell
Update Turbopack to 230308.3 (#46935)
612d578 
# Bug Fixes
- vercel/turbo#4121
- vercel/turbo#4111
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@wbinnssmith
WEB-415: next/font/google: Use next's bundled font-data.json (vercel/…
81f4f39 
…turbo#4111)

This removes the duplicated (and possibly mismatching) font data file in
favor of loading the copy bundled with next, using `load_next_json`
introduced in vercel/turbo#4086. It also removes the associated workflow and
generation script.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@wbinnssmith
WEB-415: next/font/google: Use next's bundled font-data.json (vercel/…
074630e 
…turbo#4111)

This removes the duplicated (and possibly mismatching) font data file in
favor of loading the copy bundled with next, using `load_next_json`
introduced in vercel/turbo#4086. It also removes the associated workflow and
generation script.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wbinnssmith @kwonoj