feat(ecmascript): support jsximport/runtime options #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
kwonoj
force-pushed
the
feat-jsx-import-source
branch
from
8801ca2
to
c817f15
Compare
kwonoj
force-pushed
the
feat-jsx-import-source
branch
from
c817f15
to
9175c4d
Compare
wbinnssmith
approved these changes
Mar 20, 2023
kwonoj
added
the
pr: automerge
|
This PR doesn't have a next.js counter part... |
alexkirsz
reviewed
Mar 21, 2023
Comment on lines
+38
to
+39
| // swc.jsc.transform.react.runtime, | ||
| runtime: OptionStringVc, |
There was a problem hiding this comment.
I would rather this be an enum instead, since there are only two valid values. This avoids downstream validation.
alexkirsz
added a commit
to vercel/next.js
that referenced
this pull request
Mar 21, 2023
Updates Turbopack to latest nightly and fix build errors. # New features * vercel/turbo#4198 # Bug Fixes * vercel/turbo#4241 # Misc. * vercel/turbo#4249 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part of WEB-719 implementation. PR expands enable_jsx option to accept few more configuration point to jsx transforms, mainly its import source. We'll likely to expand options more in the future.
One thing I noted in the code but didn't make change is
enable_react_refresh, if it needs to be under the jsx option or should be independent. Given react_refresh only should be enabled when jsx is enabled, for me it makes more sense to move it.