Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track invalidation reasons #4208

Merged
merged 9 commits into from Mar 16, 2023
Merged

track invalidation reasons #4208

merged 9 commits into from Mar 16, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 15, 2023

Description

tracks reasons for invalidation and reports them as updated event

fixes WEB-722
fixes WEB-221

@sokra sokra requested a review from a team as a code owner March 15, 2023 18:22
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-native-web 🔄 Building (Inspect) Mar 16, 2023 at 0:24AM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 16, 2023 at 0:24AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Mar 16, 2023 at 0:24AM (UTC)

@sokra sokra force-pushed the sokra/invalidation-reason branch from 4f2de66 to 0fef173 Compare March 15, 2023 18:27
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@padmaia
Copy link
Member

padmaia commented Mar 15, 2023

Could you add a screenshot of what the new messages look like? 🙏

@sokra
Copy link
Member Author

sokra commented Mar 16, 2023

image

(non-release mode)

crates/turbo-tasks-fs/src/invalidation.rs Show resolved Hide resolved
crates/turbo-tasks/src/invalidation_reason_set.rs Outdated Show resolved Hide resolved
crates/turbo-tasks/src/invalidation_reason_set.rs Outdated Show resolved Hide resolved
crates/turbo-tasks/src/invalidation_reason_set.rs Outdated Show resolved Hide resolved
crates/turbo-tasks/src/manager.rs Outdated Show resolved Hide resolved
crates/turbo-tasks/src/manager.rs Outdated Show resolved Hide resolved
crates/turbo-tasks/src/manager.rs Outdated Show resolved Hide resolved
crates/turbopack-dev-server/src/invalidation.rs Outdated Show resolved Hide resolved
crates/turbo-tasks-fs/src/lib.rs Outdated Show resolved Hide resolved
crates/turbo-tasks-fs/src/invalidation.rs Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Mar 16, 2023

Deployment failed with the following error:

Was unable to schedule a deployment.

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 16, 2023
@kodiakhq kodiakhq bot merged commit 84db43e into main Mar 16, 2023
26 of 27 checks passed
@kodiakhq kodiakhq bot deleted the sokra/invalidation-reason branch March 16, 2023 12:49
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 17, 2023
## Features

* vercel/turbo#4208

## Testing

* vercel/turbo#4211


Co-authored-by: Justin Ridgewell <112982+jridgewell@users.noreply.github.com>
timneutkens pushed a commit to vercel/next.js that referenced this pull request Mar 17, 2023
### What?

add reason of compilation to the `updated in` message.


![image](https://user-images.githubusercontent.com/1365881/225526729-7ada5e84-78a0-4518-ad9c-48178fd4e7cb.png)

### Why?

the general update in message is confusing and didn't show what is
happening.

Sometimes people are confused why turbopack compiles something. The new
messages explain that turbopack timings measure request handing duration
in addition to pure compilation time.

### How?

depends on vercel/turbo#4208

fixes WEB-722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants