Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build faster #4362

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Make build faster #4362

merged 2 commits into from
Jun 21, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 28, 2023 •
edited by timneutkens

Description

Testing Instructions

fix WEB-812 (link)

@vercel
Copy link

vercel bot commented Mar 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 2:58am
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 2:58am
turbo-site 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 2:58am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 2:58am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023 •
edited

🟢 CI successful 🟢

Thanks

@kdy1 kdy1 marked this pull request as ready for review March 28, 2023 14:51
@kdy1 kdy1 requested review from a team as code owners March 28, 2023 14:51
arlyon
arlyon approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@arlyon arlyon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for this for incremental builds. Is it worth force-enabling this during release (CI) builds? I realise that we haven't explicitly turned it on but lto can have pretty significant perf gains (between a few percent to 20 percent, from memory).

@sokra sokra requested a review from arlyon June 20, 2023 05:05
sokra
sokra approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but since it mostly affects Turborepo someone from Turborepo should better review it

@kdy1 kdy1 added the pr: automerge Kodiak will merge these automatically after checks pass label Jun 21, 2023
@kodiakhq kodiakhq bot merged commit dd003fd into main Jun 21, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the kdy1/build-perf branch June 21, 2023 03:13
@sokra sokra mentioned this pull request Jun 21, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jun 22, 2023
@sokra
add edge rendering for app dir for Turbopack (#51631)
99ec305 
## What

* reland #50830 
* remove Object.hasOwn
* fix CSS chunks in edge runtime

## Turbopack Changes

* vercel/turbo#5253 <!-- OJ Kwon -
fix(turbopack): enable runtime flag -->
* vercel/turbo#5295 <!-- Will Binns-Smith -
remove `__internal_nextjs_integration_test` compile-time feature -->
* vercel/turbo#4362 <!-- Donny/강동윤 - Make build
faster -->
* vercel/turbo#5352 <!-- Tobias Koppers - only
wait for JS chunks in none runtime backend -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@arlyon arlyon arlyon approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @sokra @arlyon