Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turbopack): enable runtime flag #5253

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix(turbopack): enable runtime flag #5253

merged 2 commits into from
Jun 15, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jun 8, 2023

Description

Minor fix to enable features.

@kwonoj kwonoj requested a review from a team as a code owner June 8, 2023 20:25
@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2023 8:05pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023 •
edited

⚠️ This change may fail to build next-swc.

Logs 

error: none of the selected packages contains these features: __internal_nextjs_integration_test

See job summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Linux Benchmark for b5f7271

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8997.68µs ± 35.31µs 9087.24µs ± 70.12µs +1.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8177.48µs ± 26.23µs 8356.94µs ± 203.70µs +2.19%
bench_startup/Turbopack CSR/1000 modules 914.76ms ± 1.92ms 915.97ms ± 2.65ms +0.13%

@github-actions
Copy link
Contributor

Linux Benchmark for 62e7e5f

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 4995.54µs ± 23.08µs 4975.20µs ± 38.64µs -0.41%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4632.70µs ± 25.68µs 4673.67µs ± 41.83µs +0.88%
bench_startup/Turbopack CSR/1000 modules 740.30ms ± 2.03ms 744.77ms ± 2.52ms +0.60%

@github-actions
Copy link
Contributor

Windows Benchmark for 62e7e5f

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 2712.27ms ± 8.24ms 2755.08ms ± 10.67ms +1.58% +0.18%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.51ms ± 0.01ms 15.53ms ± 0.02ms +0.17%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.47ms ± 0.01ms 15.48ms ± 0.02ms +0.09%
bench_startup/Turbopack CSR/1000 modules 2712.27ms ± 8.24ms 2755.08ms ± 10.67ms +1.58% +0.18%

@kwonoj kwonoj merged commit ebb1a42 into main Jun 15, 2023
43 of 46 checks passed
@kwonoj kwonoj deleted the fix-shared-runtime branch June 15, 2023 17:07
@sokra sokra mentioned this pull request Jun 21, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jun 22, 2023
@sokra
add edge rendering for app dir for Turbopack (#51631)
99ec305 
## What

* reland #50830 
* remove Object.hasOwn
* fix CSS chunks in edge runtime

## Turbopack Changes

* vercel/turbo#5253 <!-- OJ Kwon -
fix(turbopack): enable runtime flag -->
* vercel/turbo#5295 <!-- Will Binns-Smith -
remove `__internal_nextjs_integration_test` compile-time feature -->
* vercel/turbo#4362 <!-- Donny/강동윤 - Make build
faster -->
* vercel/turbo#5352 <!-- Tobias Koppers - only
wait for JS chunks in none runtime backend -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @wbinnssmith