Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rspack to our benchmark suite #4597

Merged
merged 3 commits into from
May 1, 2023
Merged

add rspack to our benchmark suite #4597

merged 3 commits into from
May 1, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 17, 2023

Description

allow to benchmark rspack

@sokra sokra requested a review from a team as a code owner April 17, 2023 08:19
@sokra sokra requested a review from alexkirsz April 17, 2023 08:19
@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview May 1, 2023 8:50am
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview May 1, 2023 8:50am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview May 1, 2023 8:50am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 1, 2023 8:50am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

Benchmark for aa38c59

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 856.16ms ± 0.97ms 860.45ms ± 0.99ms +0.50% +0.04%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8838.16µs ± 62.91µs 8827.49µs ± 75.28µs -0.12%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7906.94µs ± 48.88µs 7954.40µs ± 40.20µs +0.60%
bench_startup/Turbopack CSR/1000 modules 856.16ms ± 0.97ms 860.45ms ± 0.99ms +0.50% +0.04%

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra enabled auto-merge (squash) May 1, 2023 08:50
@sokra sokra merged commit 6aee9e5 into main May 1, 2023
43 of 45 checks passed
@sokra sokra deleted the sokra/rspack branch May 1, 2023 09:27
sokra added a commit to vercel/next.js that referenced this pull request May 1, 2023
### What?

fixes handling of GlobalError interop
adds a test case for client component bug

### Why?

app dir client component interop is broken

### Turbopack changes

* vercel/turbo#4597 <!-- Tobias Koppers - add
rspack to our benchmark suite -->
* vercel/turbo#4761 <!-- Tobias Koppers - Do not
use interop logic on proxy modules -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants