Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use interop logic on proxy modules #4761

Merged
merged 2 commits into from
May 1, 2023
Merged

Do not use interop logic on proxy modules #4761

merged 2 commits into from
May 1, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented May 1, 2023 •
edited

Description

Proxy modules must not use interop logic, otherwise only the default export works correctly

next.js PR: vercel/next.js#49033

@sokra sokra requested a review from a team as a code owner May 1, 2023 10:54
@vercel
Copy link

vercel bot commented May 1, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) May 1, 2023 0:02am
examples-gatsby-web 🔄 Building (Inspect) May 1, 2023 0:02am
examples-kitchensink-blog 🔄 Building (Inspect) May 1, 2023 0:02am
turbo-site 🔄 Building (Inspect) Visit Preview May 1, 2023 0:02am
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 1, 2023 0:02am
examples-cra-web ⬜️ Ignored (Inspect) May 1, 2023 0:02am
examples-native-web ⬜️ Ignored (Inspect) May 1, 2023 0:02am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 1, 2023 0:02am
examples-svelte-web ⬜️ Ignored (Inspect) May 1, 2023 0:02am
examples-tailwind-web ⬜️ Ignored (Inspect) May 1, 2023 0:02am
examples-vite-web ⬜️ Ignored (Inspect) May 1, 2023 0:02am

@sokra sokra mentioned this pull request May 1, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023 •
edited

This change may fail to build next-swc.

info: syncing channel updates for 'nightly-2023-03-09-x86_64-unknown-linux-gnu'
info: latest update on 2023-03-09, rust version 1.70.0-nightly (900c35403 2023-03-08)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
packages/next-swc/crates/next-core/src/manifest.rs:70:22: error[E0107]: trait takes 0 generic arguments but 1 generic argument was supplied
packages/next-swc/crates/next-core/src/manifest.rs:71:13: error[E0277]: the trait bound `Copied<std::slice::Iter<'_, ContentSourceVc>>: GraphStore` is not satisfied
packages/next-swc/crates/next-core/src/manifest.rs:72:13: error[E0277]: `fn(ContentSourceVc) -> impl futures::Future<Output = std::result::Result<Vec<ContentSourceVc>, anyhow::Error>> {get_content_source_children}` is not an iterator
packages/next-swc/crates/next-core/src/manifest.rs:70:22: error[E0061]: this function takes 3 arguments but 2 arguments were supplied
packages/next-swc/crates/next-core/src/manifest.rs:70:22: error[E0277]: the trait bound `Copied<std::slice::Iter<'_, ContentSourceVc>>: GraphStore` is not satisfied
packages/next-swc/crates/next-core/src/manifest.rs:74:9: error[E0277]: the trait bound `Copied<std::slice::Iter<'_, ContentSourceVc>>: GraphStore` is not satisfied
error: could not compile `next-core` (lib) due to 6 previous errors

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023 •
edited

🟢 CI successful 🟢

Thanks

@sokra sokra force-pushed the sokra/default-import-client-component branch from 984b3f0 to 7cb5ed6 Compare May 1, 2023 12:02
@sokra sokra enabled auto-merge (squash) May 1, 2023 12:02
@sokra sokra merged commit cfa8027 into main May 1, 2023
41 checks passed
@sokra sokra deleted the sokra/default-import-client-component branch May 1, 2023 12:15
sokra added a commit to vercel/next.js that referenced this pull request May 1, 2023
@sokra
fix GlobalError interop and add test case (#49033)
dbccc79 
### What?

fixes handling of GlobalError interop
adds a test case for client component bug

### Why?

app dir client component interop is broken

### Turbopack changes

* vercel/turbo#4597 <!-- Tobias Koppers - add
rspack to our benchmark suite -->
* vercel/turbo#4761 <!-- Tobias Koppers - Do not
use interop logic on proxy modules -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @alexkirsz