Configure React development flag, inherit NODE_ENV from execution context #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
|
Linux Benchmark for 9779663Click to view benchmark
|
alexkirsz
changed the title
Linux Benchmark for 5b97e8eClick to view benchmark
|
MacOS Benchmark for 5b97e8e
Click to view full benchmark
|
ForsakenHarmony
approved these changes
May 16, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
May 17, 2023
This introduces a `NextMode` enum that controls which mode Next.js Turbo is currently running in: * `NextMode::Development`: `next dev` * `NextMode::Build`: `next build` Requires vercel/turbo#4972 This also update Turbopack to `turbopack-230517.2` with the following changes: * vercel/turbo#4972 <!-- Alex Kirszenberg - Configure React development flag, inherit NODE_ENV from execution context --> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
This introduces a `NextMode` enum that controls which mode Next.js Turbo is currently running in: * `NextMode::Development`: `next dev` * `NextMode::Build`: `next build` Requires vercel/turbo#4972 This also update Turbopack to `turbopack-230517.2` with the following changes: * vercel/turbo#4972 <!-- Alex Kirszenberg - Configure React development flag, inherit NODE_ENV from execution context --> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows Turbopack users to configure the
developmentflag from the SWC React transform. This is used in vercel/next.js#49852.This PR also makes the Node.js evaluation asset context inherit its NODE_ENV from the execution context.
Testing Instructions
N/A