Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vdbg! depth and JSON error messages #5138

Merged
merged 1 commit into from May 31, 2023
Merged

Fix vdbg! depth and JSON error messages #5138

merged 1 commit into from May 31, 2023

Conversation

jridgewell
Copy link
Contributor

Description

Two small fixes:

  • The vdbg!(vc; depth = 1) macro would error out
  • The JSON error message could panic if the line and/or column was 0
    • This comes up when trying to deserialize into a struct with a missing prop, because it errors at the opening { brace

Testing Instructions

@jridgewell jridgewell requested a review from a team as a code owner May 31, 2023 06:24
@vercel
Copy link

vercel bot commented May 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview May 31, 2023 6:25am
10 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-cra-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-gatsby-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-native-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-nonmonorepo ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-svelte-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-tailwind-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am
examples-vite-web ⬜️ Ignored (Inspect) May 31, 2023 6:25am

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for d3c5c47

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8750.73µs ± 92.49µs 8795.93µs ± 72.75µs +0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7678.53µs ± 35.14µs 7686.44µs ± 252.34µs +0.10%
bench_startup/Turbopack CSR/1000 modules 864.73ms ± 1.95ms 866.57ms ± 5.27ms +0.21%

@github-actions
Copy link
Contributor

MacOS Benchmark for d3c5c47

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.42ms ± 0.47ms 56.80ms ± 3.12ms +153.38% +116.46%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 25.63ms ± 0.17ms 25.63ms ± 0.26ms +0.03%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.42ms ± 0.47ms 56.80ms ± 3.12ms +153.38% +116.46%
bench_startup/Turbopack CSR/1000 modules 2831.01ms ± 83.40ms 2898.93ms ± 64.60ms +2.40%

@alexkirsz alexkirsz merged commit 945756e into main May 31, 2023
44 of 46 checks passed
@alexkirsz alexkirsz deleted the jrl-misc-fixes branch May 31, 2023 13:15
@ForsakenHarmony ForsakenHarmony mentioned this pull request May 31, 2023
Merged
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jun 1, 2023
@ForsakenHarmony
fix @vercel/turbopack-node types (and more turbopack updates) (#50605)
eb85e79 
for #50557 

## Turbopack Updates

* vercel/turbo#5131 <!-- Tobias Koppers - sync
dependencies with next.js -->
* vercel/turbo#5138 <!-- Justin Ridgewell - Fix
`vdbg!` depth and JSON error messages -->
* vercel/turbo#5141 <!-- Leah - fix
`@vercel/turbopack-node` types by adding reference to compiled package
-->
wyattjoh pushed a commit to vercel/next.js that referenced this pull request Jun 1, 2023
@ForsakenHarmony @wyattjoh
fix @vercel/turbopack-node types (and more turbopack updates) (#50605)
e5c45b7 
for #50557 

## Turbopack Updates

* vercel/turbo#5131 <!-- Tobias Koppers - sync
dependencies with next.js -->
* vercel/turbo#5138 <!-- Justin Ridgewell - Fix
`vdbg!` depth and JSON error messages -->
* vercel/turbo#5141 <!-- Leah - fix
`@vercel/turbopack-node` types by adding reference to compiled package
-->
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@ForsakenHarmony @hydRAnger
fix @vercel/turbopack-node types (and more turbopack updates) (verc…
035ca64 
…el#50605)

for vercel#50557 

## Turbopack Updates

* vercel/turbo#5131 <!-- Tobias Koppers - sync
dependencies with next.js -->
* vercel/turbo#5138 <!-- Justin Ridgewell - Fix
`vdbg!` depth and JSON error messages -->
* vercel/turbo#5141 <!-- Leah - fix
`@vercel/turbopack-node` types by adding reference to compiled package
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jridgewell @alexkirsz