Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix @vercel/turbopack-node types by adding reference to compiled package #5141

Merged
merged 1 commit into from May 31, 2023
Merged

fix @vercel/turbopack-node types by adding reference to compiled package #5141

merged 1 commit into from May 31, 2023

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented May 31, 2023 •
edited

This broke type checking for consumers (next.js)

@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner May 31, 2023 13:58
@vercel
Copy link

vercel bot commented May 31, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 1:58pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-cra-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-native-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-svelte-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm
examples-vite-web ⬜️ Ignored (Inspect) May 31, 2023 1:58pm

@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) May 31, 2023 13:58
styfle
styfle approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony merged commit cdc98d9 into main May 31, 2023
40 of 42 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/type-fix branch May 31, 2023 14:12
@github-actions
Copy link
Contributor

Linux Benchmark for 001931e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9455.05µs ± 61.81µs 9307.54µs ± 111.76µs -1.56%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8258.25µs ± 34.02µs 8469.92µs ± 238.03µs +2.56%
bench_startup/Turbopack CSR/1000 modules 919.25ms ± 3.65ms 933.62ms ± 8.29ms +1.56%

@ForsakenHarmony ForsakenHarmony mentioned this pull request May 31, 2023
Merged
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jun 1, 2023
@ForsakenHarmony
fix @vercel/turbopack-node types (and more turbopack updates) (#50605)
eb85e79 
for #50557 

## Turbopack Updates

* vercel/turbo#5131 <!-- Tobias Koppers - sync
dependencies with next.js -->
* vercel/turbo#5138 <!-- Justin Ridgewell - Fix
`vdbg!` depth and JSON error messages -->
* vercel/turbo#5141 <!-- Leah - fix
`@vercel/turbopack-node` types by adding reference to compiled package
-->
wyattjoh pushed a commit to vercel/next.js that referenced this pull request Jun 1, 2023
@ForsakenHarmony @wyattjoh
fix @vercel/turbopack-node types (and more turbopack updates) (#50605)
e5c45b7 
for #50557 

## Turbopack Updates

* vercel/turbo#5131 <!-- Tobias Koppers - sync
dependencies with next.js -->
* vercel/turbo#5138 <!-- Justin Ridgewell - Fix
`vdbg!` depth and JSON error messages -->
* vercel/turbo#5141 <!-- Leah - fix
`@vercel/turbopack-node` types by adding reference to compiled package
-->
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@ForsakenHarmony @hydRAnger
fix @vercel/turbopack-node types (and more turbopack updates) (verc…
035ca64 
…el#50605)

for vercel#50557 

## Turbopack Updates

* vercel/turbo#5131 <!-- Tobias Koppers - sync
dependencies with next.js -->
* vercel/turbo#5138 <!-- Justin Ridgewell - Fix
`vdbg!` depth and JSON error messages -->
* vercel/turbo#5141 <!-- Leah - fix
`@vercel/turbopack-node` types by adding reference to compiled package
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ForsakenHarmony @styfle @alexkirsz