Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle dead symlinks in walk #569

Merged
merged 2 commits into from
Jan 19, 2022
Merged

fix: handle dead symlinks in walk #569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc96f1
fix: handle dead symlinks in walk
markjm Jan 18, 2022
1fcd2da
Merge branch 'main' into markjm/549
jaredpalmer Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion cli/internal/fs/copy_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ func WalkMode(rootPath string, callback func(name string, isDir bool, mode os.Fi
if isDirLike, err := info.IsDirOrSymlinkToDir(); err == nil {
return callback(name, isDirLike, info.ModeType())
} else {
return err
// Skip running callback on "dead" symlink (symlink to directory that doesn't exist)
if err, ok := err.(*os.PathError); !ok {
return err
}
return nil
}
},
Unsorted: true,
Expand Down