Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle dead symlinks in walk #569

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

markjm
Copy link
Contributor

@markjm markjm commented Jan 18, 2022

Fixes #549

The issue is due to an unhandled error bubbling in the case where a symlink exists but the target has been deleted.

Two other things to note here, which may just show my naiveté w Go (this is my first project working with it):

  1. I am unsure if there is a standard/best practice for error handling here. Seems errors can bubble/disappear really easily right now
  2. A fix like this would benefit from a regression test, but I am not too sure how the testing in this project is handled. I think even a small doc on that would be valuable. I am happy to help put that together or contribute.

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/E8KNAL9KzYbYRMZBpvozUMsw8Mu3
✅ Preview: https://turbo-site-git-fork-markjm-markjm-549.vercel.sh

@jaredpalmer jaredpalmer merged commit 44b04f1 into vercel:main Jan 19, 2022
@markjm markjm deleted the markjm/549 branch January 19, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turbo@1.0.25 doesn't detect any packages
2 participants