Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate root turbo config from package.json to turbo.json #606

Merged
merged 12 commits into from
Jan 26, 2022
Merged

Migrate root turbo config from package.json to turbo.json #606

merged 12 commits into from
Jan 26, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jan 25, 2022 •
edited

  • handle config in turbo.json
  • warn on config found in package.json
  • Update new project creation to use turbo.json
  • codemod migration to generate turbo.json
  • update examples to use turbo.json using codemod
  • update docs to direct users to create turbo.json

Fixes #217

@vercel
Copy link

vercel bot commented Jan 25, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/McbFsvyaTUm8VUfWTDFJSHdUjDv6
✅ Preview: https://turbo-site-git-feat-gsoltisturbo-config.vercel.sh

[Deployment for 8080a8b failed]

@gsoltis gsoltis marked this pull request as ready for review January 26, 2022 00:36
@jaredpalmer
Copy link
Contributor

We probably should get rid of turbo key in in implementation and docs since it is redundant when within turbo.json

jaredpalmer
jaredpalmer requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@jaredpalmer jaredpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late here. Will re-review docs in the morning

cli/internal/context/context.go Outdated Show resolved Hide resolved
cli/internal/context/context.go Outdated Show resolved Hide resolved
jaredpalmer
jaredpalmer requested changes Jan 26, 2022
View reviewed changes
cli/internal/context/context.go Outdated Show resolved Hide resolved
cli/internal/context/context.go Outdated Show resolved Hide resolved
@jaredpalmer jaredpalmer mentioned this pull request Jan 26, 2022
Closed
3 tasks
@gsoltis
Copy link
Contributor Author

gsoltis commented Jan 26, 2022

I think the build failure is because I moved the top-level config into turbo.json, but the version of turbo used to build the docs is not from this PR, so it doesn't know to use the new config. I'll revert that commit and we can update it once the deployed version of turbo has been bumped.

jaredpalmer
jaredpalmer previously approved these changes Jan 26, 2022
View reviewed changes
@jaredpalmer
Copy link
Contributor

Correct

@jaredpalmer
Copy link
Contributor

No need to revert i will update build command to use turbo@canary

@gsoltis
Copy link
Contributor Author

gsoltis commented Jan 26, 2022

Oh, ok, I'll revert the revert

@jaredpalmer jaredpalmer merged commit e6a88d2 into main Jan 26, 2022
@jaredpalmer jaredpalmer deleted the feat/gsoltis/turbo-config branch January 26, 2022 22:21
@renovate renovate bot mentioned this pull request Oct 10, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move config to turbo.json
2 participants
@gsoltis @jaredpalmer