-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix symlink handling #6246
Merged
Merged
fix symlink handling #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
✅ This change can build |
|
Linux Benchmark for bb2b025Click to view benchmark
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
timneutkens
approved these changes
Oct 22, 2023
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Oct 23, 2023
* vercel/turborepo#6241 <!-- Tobias Koppers - make the daily ci faster --> * vercel/turborepo#6242 <!-- Justin Ridgewell - Add caching to `chunk_content`'s graph walking --> * vercel/turborepo#6228 <!-- Tobias Koppers - Reduce resolve and resolving tasks --> * vercel/turborepo#6244 <!-- Tobias Koppers - avoid cloning list --> * vercel/turborepo#6246 <!-- Tobias Koppers - fix symlink handling --> Closes WEB-1819
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Incorrect handling of symlinks caused a race condition in resolving which causes weird resolving problems when a symlink is present in the same directory. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1823
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Incorrect handling of symlinks caused a race condition in resolving which causes weird resolving problems when a symlink is present in the same directory. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1823
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Incorrect handling of symlinks caused a race condition in resolving which causes weird resolving problems when a symlink is present in the same directory. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorrect handling of symlinks caused a race condition in resolving which causes weird resolving problems when a symlink is present in the same directory.
Testing Instructions
Closes WEB-1823