Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix symlink handling #6246

Merged
merged 2 commits into from
Oct 22, 2023
Merged

fix symlink handling #6246

merged 2 commits into from
Oct 22, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 22, 2023

Description

Incorrect handling of symlinks caused a race condition in resolving which causes weird resolving problems when a symlink is present in the same directory.

Testing Instructions

Closes WEB-1823

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-cra-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-gatsby-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-native-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-svelte-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-tailwind-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
examples-vite-web ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm
turbo-site ⬜️ Ignored (Inspect) Oct 22, 2023 9:43pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for bb2b025

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 12.81ms ± 1.03ms 12.57ms ± 0.93ms -1.88%
bench_hmr_to_eval/Turbopack CSR/1000 modules 12.83ms ± 1.00ms 12.38ms ± 0.93ms -3.54%
bench_startup/Turbopack CSR/1000 modules 1008.32ms ± 1.53ms 1019.10ms ± 4.76ms +1.07%

@github-actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@sokra sokra merged commit a1f9184 into main Oct 22, 2023
50 of 51 checks passed
@sokra sokra deleted the sokra/fix-symlink-handling branch October 22, 2023 22:06
sokra added a commit to vercel/next.js that referenced this pull request Oct 23, 2023
* vercel/turborepo#6241 <!-- Tobias Koppers - make
the daily ci faster -->
* vercel/turborepo#6242 <!-- Justin Ridgewell - Add
caching to `chunk_content`'s graph walking -->
* vercel/turborepo#6228 <!-- Tobias Koppers - Reduce
resolve and resolving tasks -->
* vercel/turborepo#6244 <!-- Tobias Koppers - avoid
cloning list -->
* vercel/turborepo#6246 <!-- Tobias Koppers - fix
symlink handling -->

Closes WEB-1819
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

Incorrect handling of symlinks caused a race condition in resolving
which causes weird resolving problems when a symlink is present in the
same directory.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1823
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

Incorrect handling of symlinks caused a race condition in resolving
which causes weird resolving problems when a symlink is present in the
same directory.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1823
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

Incorrect handling of symlinks caused a race condition in resolving
which causes weird resolving problems when a symlink is present in the
same directory.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants