Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encoding of chunks, fix chunk (re)loading for css #6424

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix encoding of chunks, fix chunk (re)loading for css #6424

merged 1 commit into from
Nov 13, 2023
+100 −59

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 10, 2023 •
edited
Loading

Description

We need to be consistent with url encoding
Look for existing link tags when loading CSS
allow querystring when detection existing chunks

Testing Instructions

Closes PACK-1934

@sokra
fix encoding of chunks
eaf798a 
fix chunk (re)loading for css
@sokra sokra requested a review from a team as a code owner November 10, 2023 10:32
@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-cra-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-designsystem-docs ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-gatsby-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-native-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-nonmonorepo ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-svelte-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-tailwind-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
examples-vite-web ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am
turbo-site ⬜️ Ignored (Inspect) Nov 10, 2023 10:32am

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 4147d0d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.62ms ± 0.84ms 21.54ms ± 0.82ms -0.36%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.33ms ± 0.79ms 21.19ms ± 0.85ms -0.67%
bench_startup/Turbopack CSR/1000 modules 1133.89ms ± 3.14ms 1144.57ms ± 9.77ms +0.94%

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@sokra sokra merged commit fd5d789 into main Nov 13, 2023
52 of 54 checks passed
@sokra sokra deleted the sokra/encoding-and-css-loading branch November 13, 2023 16:57
@kdy1 kdy1 mentioned this pull request Nov 13, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 15, 2023
@kdy1
Update turbopack (#58408)
f99242b 
* vercel/turborepo#6424 
* vercel/turborepo#6433 

Closes PACK-1967
@abergenw
Copy link

abergenw commented Dec 5, 2023

This makes sense, but when doing the replacement it seems like we're now looking for url encoded link tags which are not encoded in the first place?

@ForsakenHarmony
Copy link
Member

@abergenw you are correct, quick fix is in #6777

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix encoding of chunks, fix chunk (re)loading for css (vercel/turbore…
51821c8 
…po#6424)

### Description

We need to be consistent with url encoding
Look for existing link tags when loading CSS
allow querystring when detection existing chunks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-1934
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix encoding of chunks, fix chunk (re)loading for css (vercel/turbore…
ef8e469 
…po#6424)

### Description

We need to be consistent with url encoding
Look for existing link tags when loading CSS
allow querystring when detection existing chunks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-1934
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix encoding of chunks, fix chunk (re)loading for css (vercel/turbore…
c030631 
…po#6424)

### Description

We need to be consistent with url encoding
Look for existing link tags when loading CSS
allow querystring when detection existing chunks

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-1934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

@kwonoj kwonoj Awaiting requested review from kwonoj

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @abergenw @ForsakenHarmony