-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix encoding of chunks, fix chunk (re)loading for css #6424
Merged
+100
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix chunk (re)loading for css
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
✅ This change can build |
|
Linux Benchmark for 4147d0dClick to view benchmark
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
ForsakenHarmony
approved these changes
Nov 13, 2023
This makes sense, but when doing the replacement it seems like we're now looking for url encoded link tags which are not encoded in the first place? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to be consistent with url encoding
Look for existing link tags when loading CSS
allow querystring when detection existing chunks
Testing Instructions
Closes PACK-1934