Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbopack-ecmascript-runtime): handle non encoded CSS paths #6777

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Dec 12, 2023

Description

Quick fix while there might still be some characters in filenames that are not allowed in URLs

Closes PACK-2097

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:32pm
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:32pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:32pm
rust-docs ❌ Failed (Inspect) Dec 12, 2023 8:32pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:32pm

Copy link
Contributor

github-actions bot commented Dec 12, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Dec 12, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony merged commit 54872f2 into main Dec 12, 2023
47 of 49 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/pack-2097-css-hmr-fix branch December 12, 2023 20:44
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Dec 13, 2023
### Changes

* vercel/turborepo#6777 <!-- Leah -
fix(turbopack-ecmascript-runtime): handle non encoded CSS paths -->
* vercel/turborepo#6785 <!-- Tim Neutkens - Ensure
turbopack-trace-server doesn't send message in a loop -->



Closes PACK-2147
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
### Changes

* vercel/turborepo#6777 <!-- Leah -
fix(turbopack-ecmascript-runtime): handle non encoded CSS paths -->
* vercel/turborepo#6785 <!-- Tim Neutkens - Ensure
turbopack-trace-server doesn't send message in a loop -->



Closes PACK-2147
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…el/turborepo#6777)

### Description

Quick fix while there might still be some characters in filenames that
are not allowed in URLs


Closes PACK-2097
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…el/turborepo#6777)

### Description

Quick fix while there might still be some characters in filenames that
are not allowed in URLs


Closes PACK-2097
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…el/turborepo#6777)

### Description

Quick fix while there might still be some characters in filenames that
are not allowed in URLs


Closes PACK-2097
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…el/turborepo#6777)

### Description

Quick fix while there might still be some characters in filenames that
are not allowed in URLs


Closes PACK-2097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants