Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swc_core to v0.86.81 #6472

Merged
merged 8 commits into from Nov 27, 2023
Merged

Update swc_core to v0.86.81 #6472

merged 8 commits into from Nov 27, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 16, 2023 •
edited

Description

Update swc crates.

Diff: swc-project/swc@09b3003...c566b73

Testing Instructions

Let's look at the CI of next.js

next.js counterpart: vercel/next.js#58517

Closes PACK-1973

@kdy1 kdy1 self-assigned this Nov 16, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 5:23am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 5:23am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 5:23am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 5:23am

@kdy1 kdy1 mentioned this pull request Nov 16, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 changed the title Update swc_core to v0.86.63 Update swc_core to v0.86.65 Nov 17, 2023
@kdy1 kdy1 marked this pull request as ready for review November 17, 2023 02:46
@kdy1 kdy1 requested review from a team as code owners November 17, 2023 02:46
@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

arlyon
arlyon approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@arlyon arlyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping on behalf of ^repo

@kdy1 kdy1 mentioned this pull request Nov 18, 2023
Open
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for e23fd56

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 23.07ms ± 0.64ms 22.44ms ± 0.92ms -2.72%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.22ms ± 0.83ms 21.89ms ± 0.93ms -1.46%
bench_startup/Turbopack CSR/1000 modules 1103.22ms ± 5.83ms 1118.66ms ± 8.70ms +1.40%

@kdy1 kdy1 marked this pull request as draft November 20, 2023 03:35
@kdy1 kdy1 changed the title Update swc_core to v0.86.65 Update swc_core to v0.86.68 Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 609977c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.91ms ± 0.95ms 22.96ms ± 0.94ms +0.25%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.49ms ± 0.96ms 22.92ms ± 0.65ms +1.92%
bench_startup/Turbopack CSR/1000 modules 1094.94ms ± 5.96ms 1123.23ms ± 21.49ms +2.58%

@kdy1 kdy1 marked this pull request as ready for review November 20, 2023 04:12
@kdy1 kdy1 changed the title Update swc_core to v0.86.68 Update swc_core to v0.86.70 Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for ae95ab3

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.42ms ± 0.94ms 22.51ms ± 0.91ms +0.37%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.21ms ± 0.80ms 22.15ms ± 0.96ms -0.27%
bench_startup/Turbopack CSR/1000 modules 1113.95ms ± 9.04ms 1089.23ms ± 9.93ms -2.22%

@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 849e999

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.46ms ± 0.85ms 21.46ms ± 0.82ms +0.01%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.01ms ± 0.83ms 21.07ms ± 0.86ms +0.29%
bench_startup/Turbopack CSR/1000 modules 1105.48ms ± 5.49ms 1110.81ms ± 8.56ms +0.48%

@kdy1 kdy1 changed the title Update swc_core to v0.86.70 Update swc_core to v0.86.79 Nov 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 5acd9e9

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.28ms ± 0.89ms 22.28ms ± 0.91ms +0.03%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.79ms ± 0.88ms 21.84ms ± 0.89ms +0.24%
bench_startup/Turbopack CSR/1000 modules 1087.61ms ± 4.55ms 1097.72ms ± 12.91ms +0.93%

@kdy1 kdy1 marked this pull request as draft November 26, 2023 12:52
@kdy1 kdy1 changed the title Update swc_core to v0.86.79 Update swc_core to v0.86.81 Nov 26, 2023
@kdy1 kdy1 marked this pull request as ready for review November 26, 2023 18:17
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 9df8c13

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.71ms ± 0.93ms 22.79ms ± 0.94ms +0.34%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.08ms ± 0.94ms 22.43ms ± 1.01ms +1.59%
bench_startup/Turbopack CSR/1000 modules 1132.03ms ± 5.23ms 1156.12ms ± 21.29ms +2.13%

@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 1860628

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.81ms ± 0.98ms 22.78ms ± 0.97ms -0.13%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.11ms ± 0.93ms 22.20ms ± 0.95ms +0.40%
bench_startup/Turbopack CSR/1000 modules 1101.79ms ± 4.86ms 1108.80ms ± 13.08ms +0.64%

@kdy1 kdy1 added the pr: automerge Kodiak will merge these automatically after checks pass label Nov 27, 2023
@kodiakhq kodiakhq bot merged commit 790f111 into main Nov 27, 2023
52 of 54 checks passed
@kodiakhq kodiakhq bot deleted the kdy1/swc-core-86 branch November 27, 2023 07:06
AkifumiSato pushed a commit to AkifumiSato/next.js that referenced this pull request Nov 27, 2023
@kdy1 @kodiakhq
Update swc_core to v0.86.81 (vercel#58517)
8e6d51f 
### What?

Update swc crates.

Diff:
swc-project/swc@09b3003...c566b73

### Why?

To fix bugs, and improve minification.

### How?

turbopack counterpart: vercel/turbo#6472

- Closes PACK-1972

- Closes vercel#30802

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

@arlyon arlyon Awaiting requested review from arlyon

Assignees

@kdy1 kdy1

Labels
created-by: turbopack owned-by: turbopack owned-by: turborepo pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdy1 @wbinnssmith @sokra @arlyon