Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling .mjs extension resolving #6525

Merged

Conversation

timneutkens
Copy link
Member

Description

Adds support for resolving .mjs files without the extension. This is something we do currently in Next.js.

Testing Instructions

@timneutkens timneutkens requested a review from a team as a code owner November 21, 2023 14:23
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
turbo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 4:29pm
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Nov 22, 2023 4:29pm
turbo-with-mongodb-mongoose ❌ Failed (Inspect) Nov 22, 2023 4:29pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 4:29pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 4:29pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 4:29pm

@timneutkens
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 21, 2023

🟢 CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Nov 21, 2023

✅ This change can build next-swc

Copy link
Contributor

Linux Benchmark for 175b46d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 23.66ms ± 0.94ms 24.34ms ± 0.71ms +2.89%
bench_hmr_to_eval/Turbopack CSR/1000 modules 23.22ms ± 0.96ms 23.13ms ± 0.98ms -0.36%
bench_startup/Turbopack CSR/1000 modules 1094.62ms ± 5.96ms 1076.80ms ± 7.87ms -1.63%

Copy link
Contributor

Linux Benchmark for a37fd74

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 24.10ms ± 0.70ms 24.14ms ± 0.67ms +0.15%
bench_hmr_to_eval/Turbopack CSR/1000 modules 22.96ms ± 0.95ms 23.00ms ± 0.95ms +0.17%
bench_startup/Turbopack CSR/1000 modules 1135.43ms ± 3.91ms 1131.66ms ± 13.71ms -0.33%

@wbinnssmith wbinnssmith merged commit 3905991 into main Nov 22, 2023
56 of 58 checks passed
@wbinnssmith wbinnssmith deleted the 11-21-Add_support_for_enabling_.mjs_extension_resolving branch November 22, 2023 17:55
wbinnssmith added a commit to vercel/next.js that referenced this pull request Nov 22, 2023
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants