Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turbopack): Fix panic from EcmascriptModuleFacadeModule::content #7099

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix(turbopack): Fix panic from EcmascriptModuleFacadeModule::content #7099

merged 4 commits into from
Jan 29, 2024
+6 −8

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 25, 2024

Description

Testing Instructions

  1. git clone https://github.com/mrodrigues95/chatse
  2. set turbo: true under apps/web/project.json
  3. pnpm i && npx nx serve web

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:28am
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:28am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:28am
rust-docs ❌ Failed (Inspect) Jan 29, 2024 2:28am
turbo-site ✅ Ready (Inspect) Visit Preview Jan 29, 2024 2:28am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:28am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:28am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:28am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:28am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:28am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 2:28am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2024 •
edited

🟢 CI successful 🟢

Thanks

@kdy1 kdy1 marked this pull request as ready for review January 25, 2024 10:08
@kdy1 kdy1 requested a review from a team as a code owner January 25, 2024 10:08
@kdy1 kdy1 enabled auto-merge (squash) January 29, 2024 02:26
@kdy1 kdy1 merged commit 40424e2 into main Jan 29, 2024
50 of 51 checks passed
@kdy1 kdy1 deleted the kdy1/pack-2242 branch January 29, 2024 02:33
@ForsakenHarmony ForsakenHarmony mentioned this pull request Jan 29, 2024
Merged
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jan 29, 2024
@ForsakenHarmony
fix(turbopack): don't parse .ts files as .tsx (#61219)
e4b3531 
### What?

We currently parse JSX syntax in all typescript files which is wrong.

Closes PACK-2302

Turbo PR: vercel/turbo#7121

### Turbopack Updates

* vercel/turbo#7099 <!-- Donny/강동윤 -
fix(turbopack): Fix panic from `EcmascriptModuleFacadeModule::content`
-->
* vercel/turbo#7121 <!-- Leah - fix(turbopack):
don't parse `.ts` files as `.tsx` -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A task panicked: not yet implemented: EcmascriptModuleFacadeModule::content is not implemented
2 participants
@kdy1 @sokra