-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(turbopack): don't parse .ts
files as .tsx
#7121
fix(turbopack): don't parse .ts
files as .tsx
#7121
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
88b0a69
to
738f5e8
Compare
🟢 CI successful 🟢Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
/// Module with TypeScript code with references to imported types | ||
TypescriptWithTypes, | ||
TypescriptWithTypes { tsx: bool }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we convert WithTypes
into a Boolean field too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering if there's a good reason it isn't
738f5e8
to
5b98e9c
Compare
5b98e9c
to
52a9bca
Compare
### What? We currently parse JSX syntax in all typescript files which is wrong. Closes PACK-2302 Turbo PR: vercel/turbo#7121 ### Turbopack Updates * vercel/turbo#7099 <!-- Donny/강동윤 - fix(turbopack): Fix panic from `EcmascriptModuleFacadeModule::content` --> * vercel/turbo#7121 <!-- Leah - fix(turbopack): don't parse `.ts` files as `.tsx` -->
Description
We currently parse JSX syntax in all typescript files which is wrong.
Closes PACK-2302
Next.js PR: vercel/next.js#61219