Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Re-enable preset-env mode of styled-jsx in turbopack #7182

Merged
merged 3 commits into from
Jan 31, 2024
Merged

feat: Re-enable preset-env mode of styled-jsx in turbopack #7182

merged 3 commits into from
Jan 31, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 31, 2024 •
edited by padmaia
Loading

Description

Re-enable preset-env mode of styled-jsx

Testing Instructions

Tested with swc-project/plugins#259

Closes PACK-2330

@kdy1 kdy1 self-assigned this Jan 31, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 3:07am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 3:07am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 3:07am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 3:07am
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 3:07am

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@kdy1 kdy1 marked this pull request as ready for review January 31, 2024 03:06
@kdy1 kdy1 requested review from a team as code owners January 31, 2024 03:06
@kdy1 kdy1 merged commit 193cb44 into main Jan 31, 2024
51 checks passed
@kdy1 kdy1 deleted the kdy1/reapply-lcss branch January 31, 2024 07:42
@kdy1 kdy1 mentioned this pull request Jan 31, 2024
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Jan 31, 2024
@kdy1
Update turbopack (#61433)
fafcb5f 
# Turbopack

* vercel/turbo#7167 <!-- Leah - fix: catch
import map lookup error properly in `ResolvingIssue` -->
* vercel/turbo#7182 <!-- Donny/강동윤 - feat:
Re-enable `preset-env` mode of `styled-jsx` in turbopack -->
* vercel/turbo#7161 <!-- Tobias Koppers - add
support for globs in sideEffects field in package.json -->
* vercel/turbo#7184 <!-- Donny/강동윤 - chore:
Update `swc_core` to `v0.89.6` -->

### What?

Update turbopack

### Why?

To test vercel/turbo#7182 against internal
webapps.

### How?

 - Closes #57718

Closes PACK-2334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

Assignees

@kdy1 kdy1

Labels
created-by: turbopack owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @sokra