Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for globs in sideEffects field in package.json #7161

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 30, 2024

Description

fixes PACK-2092

Testing Instructions

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 10:54pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 10:54pm
rust-docs ❌ Failed (Inspect) Jan 30, 2024 10:54pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 10:54pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2024 10:54pm

Copy link
Contributor

github-actions bot commented Jan 30, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jan 30, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 7631655 into main Jan 31, 2024
48 of 51 checks passed
@sokra sokra deleted the sokra/side-effects-glob branch January 31, 2024 09:28
kdy1 added a commit to vercel/next.js that referenced this pull request Jan 31, 2024
# Turbopack

* vercel/turborepo#7167 <!-- Leah - fix: catch
import map lookup error properly in `ResolvingIssue` -->
* vercel/turborepo#7182 <!-- Donny/강동윤 - feat:
Re-enable `preset-env` mode of `styled-jsx` in turbopack -->
* vercel/turborepo#7161 <!-- Tobias Koppers - add
support for globs in sideEffects field in package.json -->
* vercel/turborepo#7184 <!-- Donny/강동윤 - chore:
Update `swc_core` to `v0.89.6` -->

### What?

Update turbopack

### Why?

To test vercel/turborepo#7182 against internal
webapps.

### How?

 - Closes #57718

Closes PACK-2334
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…rborepo#7161)

### Description

fixes PACK-2092

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…rborepo#7161)

### Description

fixes PACK-2092

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…rborepo#7161)

### Description

fixes PACK-2092

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…rborepo#7161)

### Description

fixes PACK-2092

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants