Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate calls of bindings correctly without this context #7625

Merged
merged 2 commits into from Mar 5, 2024
Merged

generate calls of bindings correctly without this context #7625

merged 2 commits into from Mar 5, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 5, 2024 •
edited by padmaia

Description

import { method } from "module";

method()

method will be called this = undefined as intended.

Testing Instructions

Closes PACK-2663

@sokra sokra requested a review from a team as a code owner March 5, 2024 15:49
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Mar 5, 2024 3:57pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 3:57pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-gatsby-web ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-native-web ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-svelte-web ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm
examples-vite-web ⬜️ Ignored (Inspect) Mar 5, 2024 3:57pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 0ce3954 into main Mar 5, 2024
46 of 48 checks passed
@sokra sokra deleted the sokra/binding-call-this-context branch March 5, 2024 16:09
@kdy1 kdy1 mentioned this pull request Mar 7, 2024
Merged
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 7, 2024
@kdy1
Update turbopack (#62971)
03d89bc 
# Turbopack

* vercel/turbo#7625 <!-- Tobias Koppers -
generate calls of bindings correctly without this context -->
* vercel/turbo#7621 <!-- Donny/강동윤 - fix: Fix
purity lint for CSS Modules in swc mode -->
* vercel/turbo#7640 <!-- Tobias Koppers - very
dynamic requests will only lead to a warning -->
* vercel/turbo#7639 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.17` -->


### What?

Update turbopack

### Why?

To keep in sync

### How?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sokra @timneutkens