[turbo trace] add ability to filter by value and occurences #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
arlyon
force-pushed
the
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
branch
from
f7624f1
to
cc8a7d1
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
46b7cf3
to
aa14884
Compare
arlyon
force-pushed
the
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
branch
from
cc8a7d1
to
6c2de7a
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
aa14884
to
9241414
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
9241414
to
9b6e234
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
9b6e234
to
9139a05
Compare
arlyon
force-pushed
the
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
branch
from
6c2de7a
to
a959ee1
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
9139a05
to
c9e26bc
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
08ad50d
to
ed4bedc
Compare
ForsakenHarmony
approved these changes
May 15, 2024
arlyon
force-pushed
the
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
branch
from
b8ba8c3
to
32d0747
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
ed4bedc
to
7a20d4d
Compare
arlyon
force-pushed
the
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
branch
from
32d0747
to
4c292ac
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
7a20d4d
to
07e95b9
Compare
arlyon
force-pushed
the
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
branch
from
4c292ac
to
19d73f2
Compare
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
07e95b9
to
003b9b0
Compare
Base automatically changed from
03-08-add_additional_filter_modes_for_allocation_and_alloc_count_over_time
to
main
May 22, 2024 11:11
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
003b9b0
to
f0c3166
Compare
bgw
approved these changes
May 31, 2024
arlyon
force-pushed
the
03-08-add_ability_to_filter_by_value_and_occurences
branch
from
f0c3166
to
1b49d92
Compare
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jun 5, 2024
# Turbopack * vercel/turbo#8272 <!-- Donny/강동윤 - feat: Update `swc_core` to `v0.92.8` --> * vercel/turbo#8262 <!-- Alexander Lyon - add crate to calculate prehashes --> * vercel/turbo#8174 <!-- Tobias Koppers - use prehash to avoid rehashing the key in the task cache --> * vercel/turbo#7674 <!-- Alexander Lyon - [turbo trace] add ability to filter by value and occurences --> * vercel/turbo#8287 <!-- Donny/강동윤 - feat: Update `swc_core` to `v0.92.10` --> * vercel/turbo#8037 <!-- Alexander Lyon - create turbo-static for compile time graph analysis --> * vercel/turbo#8293 <!-- Will Binns-Smith - Sync Cargo.lock with Next.js --> * vercel/turbo#8239 <!-- Benjamin Woodruff - Reduce amount of code generated by ValueDebugFormat --> * vercel/turbo#8304 <!-- Benjamin Woodruff - Minor optimizations to the codegen of TaskFnInputFunction --> * vercel/turbo#8221 <!-- Donny/강동윤 - perf: Introduce `RcStr` --> ### What? I tried using `Arc<String>` in vercel/turbo#7772, but a team member suggested creating a new type so we can replace underlying implementation easily in the future. ### Why? To reduce memory usage. ### How? Closes PACK-2776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds extra filtering options to the trace server to limit by some concrete value and occurences. There is an accompanying PR for the trace-viewer to add filtering options to the web UI
Testing Instructions
Closes TURBO-2575