New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mechanism to bypass turbo engine for annotated methods #7675
base: 03-08-add_ability_to_filter_by_value_and_occurences
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
46b7cf3
to
aa14884
Compare
92ad696
to
de937a1
Compare
if has_attribute(&fn_item.attrs, "function") | ||
&& !ignored::task_ignored(&fn_item.sig.ident.to_string()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A problem is probably that just ignoring the attribute is not enough. The attribute is also changing the signature, e. g. async fn X() -> Result<Vc<Y>>
becomes fn X() -> Vc<Y>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I am going to see if it is possible to rewrite the signatures as well, have been messing around with it today to see if we can do that without requiring upstream tasks to change
aa14884
to
9241414
Compare
de937a1
to
4615e87
Compare
9241414
to
9b6e234
Compare
4615e87
to
abe08f2
Compare
9b6e234
to
9139a05
Compare
abe08f2
to
8224476
Compare
9139a05
to
c9e26bc
Compare
f53a525
to
9f50dd4
Compare
51a0259
to
01f812c
Compare
9f50dd4
to
d49e885
Compare
01f812c
to
08ad50d
Compare
d49e885
to
fbab81c
Compare
08ad50d
to
ed4bedc
Compare
fbab81c
to
739c4e3
Compare
ed4bedc
to
7a20d4d
Compare
739c4e3
to
2671771
Compare
This PR still needs some work, since we will need to transparently forward VCs or eagerly evaluate them. We need to ensure that the parent task is still lazy, but that we are just cutting out task tracking between tasks.
7a20d4d
to
07e95b9
Compare
2671771
to
3fb2eb1
Compare
07e95b9
to
003b9b0
Compare
Description
Testing Instructions
Closes TURBO-2576