Turbopack HMR: url-encode sourceURLs #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, URLs with spaces (such as those with `[root of dev server]`) were not understood by tools like Chrome’s dev tools. Test Plan: Test with an upcoming Next.js PR (to be linked below)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
kwonoj
approved these changes
Mar 8, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Mar 8, 2024
In addition to the file path, also url-decode the module name (represented by the `id` query parameter). Test Plan: Together with vercel/turbo#7682, this fixes `pnpm testonly-dev test/development/basic/hmr.test.ts "should recover from errors in the render function"`
|
wbinnssmith
changed the title
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Mar 9, 2024
In addition to the file path, also url-decode the module name (represented by the `id` query parameter). Test Plan: Together with vercel/turbo#7682, this fixes `pnpm testonly-dev test/development/basic/hmr.test.ts "should recover from errors in the render function"` Closes PACK-2700
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Mar 11, 2024
# Turbopack * vercel/turbo#7682 <!-- Will Binns-Smith - Turbopack HMR: url-encode sourceURLs --> * vercel/turbo#7524 <!-- Donny/강동윤 - feat(turbopack): Enable lightningcss for turbopack by default --> ### What? Enable lightningcss by default, for `--turbo` mode. ### Why? It's time to do it 😄 ### How? Turbopack counterpart: vercel/turbo#7524 Closes PACK-2600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, URLs with spaces (such as those with
[root of dev server]) were not understood by tools like Chrome’s dev tools.Test Plan: Test with an upcoming Next.js PR (to be linked below)
Closes PACK-2699