Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some small bugs in turbo-tasks that are required for GC #7764

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 19, 2024

Description

  • disable GC for tasks which use the streaming hack
  • invalidate dependent tasks when assigning to a recomputing cell

Testing Instructions

Closes PACK-2787

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Mar 19, 2024 3:52pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:52pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-gatsby-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-native-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-svelte-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm
examples-vite-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:52pm

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Mar 19, 2024

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit 48a2727 into main Mar 22, 2024
50 checks passed
@sokra sokra deleted the sokra/task-fixes branch March 22, 2024 13:32
kdy1 added a commit to vercel/next.js that referenced this pull request Mar 25, 2024
# Turbopack

* vercel/turbo#7815 <!-- Tobias Koppers - fix
alias in getResolve -->
* vercel/turbo#7796 <!-- Donny/강동윤 - Update
`swc_core` to `v0.90.24` -->
* vercel/turbo#7775 <!-- Tobias Koppers - fix
single css chunks with import context -->
* vercel/turbo#7776 <!-- Tobias Koppers - change
port of trace-server -->
* vercel/turbo#7763 <!-- Tobias Koppers -
Tracing improvements -->
* vercel/turbo#7813 <!-- Tobias Koppers - fix
webpack loader incorrectly calling custom_evaluate -->
* vercel/turbo#7764 <!-- Tobias Koppers - fix
some small bugs in turbo-tasks that are required for GC -->
* vercel/turbo#7816 <!-- Chris Olszewski -
chore: remove some unused imports -->
* vercel/turbo#7823 <!-- OJ Kwon -
fix(sourcemap): update sourcemap, remove checker -->

### What?

Update SWC crates to
swc-project/swc@ad932f0

### Why?

To keep in sync.

### How?



 - Closes PACK-2807
 - Closes PACK-2819

---------

Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants