feat(turborepo): Persistent Tasks in Watch Mode #7922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
e35643c
to
8841992
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
d85286a
to
87e13f4
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
8841992
to
0adec70
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
87e13f4
to
0d4f68d
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
0adec70
to
d8609f2
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
0d4f68d
to
02a5e85
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
14a2f79
to
df46f8a
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
02a5e85
to
24a0c13
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
8b2029b
to
5c639c5
Compare
gsoltis
reviewed
Apr 23, 2024
| if run.has_persistent_tasks() { | ||
| // Abort old run | ||
| if let Some(run) = persistent_tasks_handle.take() { | ||
| run.abort(); |
There was a problem hiding this comment.
Does this run synchronously? Do we need to await the handle after calling abort?
There was a problem hiding this comment.
So the actual cancelation will likely happen at the next await point. We don't need to await the handle.
gsoltis
approved these changes
Apr 23, 2024
This was referenced May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements handling of persistent tasks. Basically, we strip out any persistent tasks from the task graph when we do either an execution for package rediscovery or package changes. Instead, we run the persistent tasks in a separate thread, so they don't block anything.
Testing Instructions
Added tests for both pruning methods.
Closes TURBO-2775