feat: Re-run dependent tasks in watch mode #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
This was referenced Apr 3, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
8dcda98
to
f54abf8
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
16b275d
to
87e072d
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
f54abf8
to
4a108fe
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
87e072d
to
5c05818
Compare
NicholasLYang
changed the title
NicholasLYang
requested review from
gsoltis and
arlyon
and removed request for
a team
NicholasLYang
commented
Apr 5, 2024
NicholasLYang
commented
Apr 5, 2024
NicholasLYang
commented
Apr 5, 2024
| @@ -433,6 +460,12 @@ impl RunBuilder { | |||
| })) | |||
| .build()?; | |||
|
|
|||
| // If we have an initial task, we prune out the engine to only | |||
| // tasks that are reachable from that initial task. | |||
| if let Some(entrypoint_tasks) = &self.entrypoint_tasks { | |||
There was a problem hiding this comment.
This is a little hacky, but I couldn't figure out how to do this otherwise without cloning Run and we can't implement Clone on Run since we have the AnalyticsHandle.
There was a problem hiding this comment.
Are we rebuilding the original task graph each time?
There was a problem hiding this comment.
We might want to consider separating the Engine from an instance of Run. Run isn't really meant to be reusable, but it might take a little work to make it possible to use multiple of them.
There was a problem hiding this comment.
Yeah I think we need to work out what exactly is reusable and what is persistent across runs. Like we can reuse the same analytics handle and cache handle, but maybe not the same task graph
NicholasLYang
commented
Apr 5, 2024
| self | ||
| } | ||
|
|
||
| pub fn hide_prelude(mut self) -> Self { |
There was a problem hiding this comment.
I added this because the prelude makes less sense with re-run tasks. It prints the packages in scope, but the tasks in those packages are not always run, since the task graph is pruned.
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
10e9bfb
to
c29cbf0
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
8841992
to
0adec70
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
c29cbf0
to
b86a547
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
0adec70
to
d8609f2
Compare
gsoltis
reviewed
Apr 16, 2024
| @@ -425,6 +448,12 @@ impl RunBuilder { | |||
| })) | |||
| .build()?; | |||
|
|
|||
| // If we have an initial task, we prune out the engine to only | |||
| // tasks that are reachable from that initial task. | |||
| if let Some(entrypoint_package) = &self.entrypoint_package { | |||
There was a problem hiding this comment.
I think this will eventually need to be a set of packages, especially with debouncing and waiting for current runs to finish being cancelled or completed
gsoltis
approved these changes
Apr 16, 2024
NicholasLYang
force-pushed
the
nicholasyang/watch-mode
branch
from
b86a547
to
aac815a
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-walker
branch
from
14a2f79
to
df46f8a
Compare
NicholasLYang
added a commit
that referenced
this pull request
Apr 19, 2024
Instead of using `--filter` in our re-running of tasks for watch mode, we instead prune the task graph to run the changed task and its dependent tasks. This has the benefit of following the task graph and not the package graph. You can verify this works by creating a task dependency relation that is not in the package graph. So, make a `ui#test` task that depends on a `docs#test` task, but don't have `ui` depend on `docs`. Then verify that when the `docs` are changed, we re-run the `ui#test` task too. Closes TURBO-2752
NicholasLYang
added a commit
that referenced
this pull request
Apr 19, 2024
Instead of using `--filter` in our re-running of tasks for watch mode, we instead prune the task graph to run the changed task and its dependent tasks. This has the benefit of following the task graph and not the package graph. You can verify this works by creating a task dependency relation that is not in the package graph. So, make a `ui#test` task that depends on a `docs#test` task, but don't have `ui` depend on `docs`. Then verify that when the `docs` are changed, we re-run the `ui#test` task too. Closes TURBO-2752
NicholasLYang
added a commit
that referenced
this pull request
Apr 19, 2024
Instead of using `--filter` in our re-running of tasks for watch mode, we instead prune the task graph to run the changed task and its dependent tasks. This has the benefit of following the task graph and not the package graph. You can verify this works by creating a task dependency relation that is not in the package graph. So, make a `ui#test` task that depends on a `docs#test` task, but don't have `ui` depend on `docs`. Then verify that when the `docs` are changed, we re-run the `ui#test` task too. Closes TURBO-2752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using
--filterin our re-running of tasks for watch mode, we instead prune the task graph to run the changed task and its dependent tasks. This has the benefit of following the task graph and not the package graph.Testing Instructions
You can verify this works by creating a task dependency relation that is not in the package graph. So, make a
ui#testtask that depends on adocs#testtask, but don't haveuidepend ondocs. Then verify that when thedocsare changed, we re-run theui#testtask too.Closes TURBO-2752