chore(ci): remove invalid action argument #7978
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
examples tests don't run on a matrix, so it will never be on windows. The default is already false.
mehulkar
force-pushed
the
mehulkar-patch-1
branch
from
a716cfc
to
89509a2
Compare
|
| @@ -221,7 +221,7 @@ jobs: | |||
|
|
|||
| - uses: ./.github/actions/setup-turborepo-environment | |||
| with: | |||
| windows: ${{ matrix.os.name == 'windows' }} | |||
| windows: ${{ matrix.os.runner == 'windows-latest' }} | |||
There was a problem hiding this comment.
Was there an issue with the previous comparison? Just making sure I'm not missing something with this change.
There was a problem hiding this comment.
you aren't missing anything. I just realized that runner is a real thing in the matrix, where the name key is made up by the user (us), and could be dropped with no effect on the matrix. So I'd rather compare to the real thing. E.g in integration tests, I didn't even put a name , because it doesn't matter:
turbo/.github/workflows/test.yml
Lines 255 to 259 in 29e73ad
| @@ -658,7 +654,7 @@ jobs: | |||
| - name: Setup Turborepo Environment | |||
| uses: ./.github/actions/setup-turborepo-environment | |||
| with: | |||
| windows: ${{ matrix.os.name == 'windows' }} | |||
| windows: ${{ matrix.os.runner == 'windows-latest' }} | |||
There was a problem hiding this comment.
Again, was there an issue with the previous comparison with name?
Closes TURBO-2814