Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): remove invalid action argument #7978

Merged
merged 2 commits into from Apr 16, 2024
Merged

chore(ci): remove invalid action argument #7978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89509a2
chore(ci): remove invalid action argument
mehulkar Apr 16, 2024
9e9ff8f
rm some more unused args
mehulkar Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -221,7 +221,7 @@ jobs:

- uses: ./.github/actions/setup-turborepo-environment
with:
windows: ${{ matrix.os.name == 'windows' }}
windows: ${{ matrix.os.runner == 'windows-latest' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there an issue with the previous comparison? Just making sure I'm not missing something with this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you aren't missing anything. I just realized that runner is a real thing in the matrix, where the name key is made up by the user (us), and could be dropped with no effect on the matrix. So I'd rather compare to the real thing. E.g in integration tests, I didn't even put a name , because it doesn't matter:

turbo/.github/workflows/test.yml

Lines 255 to 259 in 29e73ad

matrix:
os:
- runner: ubuntu-latest
- runner: macos-latest
- runner: windows-latest

github-token: "${{ secrets.GITHUB_TOKEN }}"
# We explicitly unset RUSTC_WRAPPER if it is an empty string as causes build issues
- run: |
Expand Down Expand Up @@ -310,7 +310,6 @@ jobs:

- uses: ./.github/actions/setup-turborepo-environment
with:
windows: ${{ matrix.os.runner == 'windows-latest' }}
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Check examples
Expand Down Expand Up @@ -367,7 +366,6 @@ jobs:
- name: Build turborepo CLI from source
uses: ./.github/actions/setup-turborepo-environment
with:
windows: ${{ matrix.os.name == 'windows' }}
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Run tests
Expand Down Expand Up @@ -459,7 +457,6 @@ jobs:
- name: Setup Turborepo Environment
uses: ./.github/actions/setup-turborepo-environment
with:
windows: ${{ matrix.os.name == 'windows' }}
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Run cargo check
Expand All @@ -481,7 +478,6 @@ jobs:
- name: Setup Turborepo Environment
uses: ./.github/actions/setup-turborepo-environment
with:
windows: ${{ matrix.os.name == 'windows' }}
github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Run cargo clippy
Expand Down Expand Up @@ -658,7 +654,7 @@ jobs:
- name: Setup Turborepo Environment
uses: ./.github/actions/setup-turborepo-environment
with:
windows: ${{ matrix.os.name == 'windows' }}
windows: ${{ matrix.os.runner == 'windows-latest' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, was there an issue with the previous comparison with name?

github-token: "${{ secrets.GITHUB_TOKEN }}"

- name: Run tests
Expand Down