Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack HMR: Avoid infinite loops caused by cycles between modules in the dependency chain. #8210

Merged
merged 4 commits into from
May 28, 2024

Conversation

wbinnssmith
Copy link
Member

Previously, if a change were made in a module that participated in a dependency cycle, gathering affected modules would loop infinitely. This check prevents this.

Test Plan: Fixes vercel/next.js#65537

…in the dependency chain.

Previously, if a change were made in a module that participated in a dependency cycle, gathering affected modules would loop infinitely. This check prevents this.

Test Plan: Fixes vercel/next.js#65537
@wbinnssmith wbinnssmith requested a review from a team as a code owner May 23, 2024 22:38
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 8:52pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 28, 2024 8:52pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 8:52pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 8:52pm

Copy link
Contributor

github-actions bot commented May 23, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 23, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented May 23, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@wbinnssmith wbinnssmith merged commit 1446abf into main May 28, 2024
54 of 56 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/hmr-cycle branch May 28, 2024 22:12
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…in the dependency chain. (vercel/turborepo#8210)

Previously, if a change were made in a module that participated in a
dependency cycle, gathering affected modules would loop infinitely. This
check prevents this.

Test Plan: Fixes #65537
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…in the dependency chain. (vercel/turborepo#8210)

Previously, if a change were made in a module that participated in a
dependency cycle, gathering affected modules would loop infinitely. This
check prevents this.

Test Plan: Fixes #65537
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…in the dependency chain. (vercel/turborepo#8210)

Previously, if a change were made in a module that participated in a
dependency cycle, gathering affected modules would loop infinitely. This
check prevents this.

Test Plan: Fixes #65537
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…in the dependency chain. (vercel/turborepo#8210)

Previously, if a change were made in a module that participated in a
dependency cycle, gathering affected modules would loop infinitely. This
check prevents this.

Test Plan: Fixes #65537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload causes tab to hang and crash
3 participants