Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only create spans for nodes that are actually visited #8508

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 15, 2024

Description

avoiding too many spans

Testing Instructions

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 6:05pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 6:05pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-native-web ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 15, 2024 6:05pm

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jun 15, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra requested a review from arlyon June 15, 2024 18:38
@sokra sokra merged commit 3006bab into main Jun 17, 2024
55 of 58 checks passed
@sokra sokra deleted the sokra/less-spans-on-tranversal branch June 17, 2024 11:10
kdy1 added a commit to vercel/next.js that referenced this pull request Jun 18, 2024
# Turbopack

* vercel/turbo#8473 <!-- Donny/강동윤 - feat: Check
the number of direct dependants while tree shaking -->
* vercel/turbo#8420 <!-- Tobias Koppers - Tree
Shaking grouping of items -->
* vercel/turbo#8510 <!-- Tobias Koppers - read
larger chunks when reading a trace file -->
* vercel/turbo#8509 <!-- Tobias Koppers - avoid
duplicates in primary_modules -->
* vercel/turbo#8508 <!-- Tobias Koppers - only
create spans for nodes that are actually visited -->
* vercel/turbo#8502 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.95.2` -->


### What?

Update `swc_core`.

- [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15)


### Why?

I improved the performance of the parser by margin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants