Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce size of task output struct #8557

Merged
merged 2 commits into from
Jun 26, 2024
Merged

reduce size of task output struct #8557

merged 2 commits into from
Jun 26, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 20, 2024

Description

remove unused updates counter
box rarely used panic enum variant to reduce enum size

Testing Instructions

@sokra sokra requested a review from a team as a code owner June 20, 2024 20:30
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:30pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:30pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-native-web ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 20, 2024 8:30pm

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

@sokra sokra requested a review from bgw June 20, 2024 20:36
Copy link
Contributor

github-actions bot commented Jun 20, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 11d72d4 into main Jun 26, 2024
55 of 57 checks passed
@sokra sokra deleted the sokra/task-output-size branch June 26, 2024 09:11
timneutkens added a commit to vercel/next.js that referenced this pull request Jun 26, 2024
* vercel/turbo#8546 <!-- Benjamin Woodruff -
Decrease default scope_stress test size, add env var config -->
* vercel/turbo#8563 <!-- Donny/강동윤 - Update
`swc_core` to `v0.95.4` -->
* vercel/turbo#8556 <!-- Tobias Koppers - avoid
cloning the source code -->
* vercel/turbo#8562 <!-- Will Binns-Smith - HMR:
handle non-Latin characters in text through base64-encoded sourcemaps
-->
* vercel/turbo#8530 <!-- Benjamin Woodruff -
Support turbo tasks inside of `mod` blocks -->
* vercel/turbo#8542 <!-- Benjamin Woodruff -
Handle `#[cfg(...)]` attributes on turbo tasks -->
* vercel/turbo#8529 <!-- Benjamin Woodruff -
Deduplicate persistent task get_function_name logic -->
* vercel/turbo#8547 <!-- Benjamin Woodruff - Add
new ExitHandler API as an alternative to ExitGuard -->
* vercel/turbo#8604 <!-- Benjamin Woodruff -
Delete unused TASK_ID_MAPPING support -->
* vercel/turbo#8605 <!-- Benjamin Woodruff -
Remove nohash-hasher dependency -->
* vercel/turbo#8559 <!-- Tobias Koppers - move
stateful flag into Done state -->
* vercel/turbo#8598 <!-- Tim Neutkens - MDX
support: Ensure development transform is only used in development -->
* vercel/turbo#8557 <!-- Tobias Koppers - reduce
size of task output struct -->
* vercel/turbo#8558 <!-- Tobias Koppers - remove
prepared task type -->


<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants