Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix constant width for checkmark #8702

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dimitropoulos
Copy link
Contributor

Description

The unicode codepoint (✔) we used for a checkmark is not monospace on some platforms (i.e. linux).

This PR updates that to use the characters matching Next.JS (and many other CLI tools before it). Prior to this PR, this resulted in the checkmark overflowing its boundary into the border.

BEFORE AFTER
image image

Testing Instructions

cargo tr-build
./target/debug/turbo test --filter "./packages/*" --continue --force

@dimitropoulos dimitropoulos requested a review from a team as a code owner July 9, 2024 18:21
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 6:21pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 6:21pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-native-web ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-svelte-web ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm
examples-vite-web ⬜️ Ignored (Inspect) Jul 9, 2024 6:21pm

@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Jul 9, 2024
@ijjk
Copy link
Member

ijjk commented Jul 9, 2024

Allow CI Workflow Run

  • approve CI run for commit: 26f6070

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

github-actions bot commented Jul 9, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jul 9, 2024

🟢 CI successful 🟢

Thanks

@dimitropoulos dimitropoulos enabled auto-merge (squash) July 9, 2024 18:31
@chris-olszewski chris-olszewski merged commit adcb85c into main Jul 9, 2024
64 of 65 checks passed
@chris-olszewski chris-olszewski deleted the dimitri/TURBO-3697-constant-width branch July 9, 2024 20:29
kodiakhq bot pushed a commit to technifit/tasker that referenced this pull request Jul 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [eslint-config-turbo](https://togithub.com/vercel/turbo) ([source](https://togithub.com/vercel/turbo/tree/HEAD/packages/eslint-config-turbo)) | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/eslint-config-turbo/2.0.6/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`2.0.6` -> `2.0.7`](https://renovatebot.com/diffs/npm/turbo/2.0.6/2.0.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/turbo (eslint-config-turbo)</summary>

### [`v2.0.7`](https://togithub.com/vercel/turbo/releases/tag/v2.0.7): Turborepo v2.0.7

[Compare Source](https://togithub.com/vercel/turbo/compare/v2.0.6...v2.0.7)



##### What's Changed

##### Examples

-   Fix lockfile in kitchen-sink. by [@&#8203;anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#8666
-   fix(examples): correct next.config extension in tsconfig by [@&#8203;moolcoov](https://togithub.com/moolcoov) in [vercel/turbo#8638
-   feat(examples): add `with-nestjs` example by [@&#8203;Neosoulink](https://togithub.com/Neosoulink) in [vercel/turbo#8162

##### Changelog

-   (refactor)ui: Refactoring/simplifying TUI state by [@&#8203;anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#8650
-   fix: add more windows vars to default pass through env by [@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#8615
-   Add Docker to default passthroughs list. by [@&#8203;anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#8690
-   Add VSCode's debugger variables to default passthroughs. by [@&#8203;anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#8689
-   update env_wildcards for SvelteKit by [@&#8203;jacksteamdev](https://togithub.com/jacksteamdev) in [vercel/turbo#8685
-   fix constant width for checkmark by [@&#8203;dimitropoulos](https://togithub.com/dimitropoulos) in [vercel/turbo#8702
-   fix(ui): respect `--output-logs` and `outputLogs` for persisting logs after TUI exits by [@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#8612
-   fix(ui): only start ui if there are tasks to run by [@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#8703
-   chore(ui): add tracing to all tui operations by [@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#8704
-   adds CLI flag for controlling tui/stream by [@&#8203;dimitropoulos](https://togithub.com/dimitropoulos) in [vercel/turbo#8714
-   feat: allow opting out of required package manager by [@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#8738
-   upgrade deps to avoid conflict with next.js by [@&#8203;sokra](https://togithub.com/sokra) in [vercel/turbo#8750
-   refactor(turborepo): derive `Opts` from `Config` by [@&#8203;NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#8759

##### New Contributors

-   [@&#8203;dimitropoulos](https://togithub.com/dimitropoulos) made their first contribution in [vercel/turbo#8674
-   [@&#8203;pathliving](https://togithub.com/pathliving) made their first contribution in [vercel/turbo#8675
-   [@&#8203;UNRULYEON](https://togithub.com/UNRULYEON) made their first contribution in [vercel/turbo#8679
-   [@&#8203;LaPulgaaa](https://togithub.com/LaPulgaaa) made their first contribution in [vercel/turbo#8683
-   [@&#8203;jacksteamdev](https://togithub.com/jacksteamdev) made their first contribution in [vercel/turbo#8685
-   [@&#8203;ony3000](https://togithub.com/ony3000) made their first contribution in [vercel/turbo#8642
-   [@&#8203;moolcoov](https://togithub.com/moolcoov) made their first contribution in [vercel/turbo#8638
-   [@&#8203;pkellner](https://togithub.com/pkellner) made their first contribution in [vercel/turbo#8669
-   [@&#8203;vinnymac](https://togithub.com/vinnymac) made their first contribution in [vercel/turbo#8637
-   [@&#8203;torresgol10](https://togithub.com/torresgol10) made their first contribution in [vercel/turbo#8719
-   [@&#8203;baileywickham](https://togithub.com/baileywickham) made their first contribution in [vercel/turbo#8692
-   [@&#8203;LioRael](https://togithub.com/LioRael) made their first contribution in [vercel/turbo#8741
-   [@&#8203;mischnic](https://togithub.com/mischnic) made their first contribution in [vercel/turbo#8767

**Full Changelog**: vercel/turbo@v2.0.6...v2.0.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/technifit/tasker).
renovate bot added a commit to inabagumi/shinju-date that referenced this pull request Jul 16, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [eslint-config-turbo](https://togithub.com/vercel/turbo)
([source](https://togithub.com/vercel/turbo/tree/HEAD/packages/eslint-config-turbo))
| [`^2.0.6` ->
`^2.0.7`](https://renovatebot.com/diffs/npm/eslint-config-turbo/2.0.6/2.0.7)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-config-turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-config-turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [turbo](https://turbo.build/repo)
([source](https://togithub.com/vercel/turbo)) | [`^2.0.6` ->
`^2.0.7`](https://renovatebot.com/diffs/npm/turbo/2.0.6/2.0.7) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/turbo/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.0.6/2.0.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vercel/turbo (eslint-config-turbo)</summary>

### [`v2.0.7`](https://togithub.com/vercel/turbo/releases/tag/v2.0.7):
Turborepo v2.0.7

[Compare
Source](https://togithub.com/vercel/turbo/compare/v2.0.6...v2.0.7)

<!-- Release notes generated using configuration in
.github/turborepo-release.yml at v2.0.7 -->

##### What's Changed

##### Examples

- Fix lockfile in kitchen-sink. by
[@&#8203;anthonyshew](https://togithub.com/anthonyshew) in
[vercel/turbo#8666
- fix(examples): correct next.config extension in tsconfig by
[@&#8203;moolcoov](https://togithub.com/moolcoov) in
[vercel/turbo#8638
- feat(examples): add `with-nestjs` example by
[@&#8203;Neosoulink](https://togithub.com/Neosoulink) in
[vercel/turbo#8162

##### Changelog

- (refactor)ui: Refactoring/simplifying TUI state by
[@&#8203;anthonyshew](https://togithub.com/anthonyshew) in
[vercel/turbo#8650
- fix: add more windows vars to default pass through env by
[@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in
[vercel/turbo#8615
- Add Docker to default passthroughs list. by
[@&#8203;anthonyshew](https://togithub.com/anthonyshew) in
[vercel/turbo#8690
- Add VSCode's debugger variables to default passthroughs. by
[@&#8203;anthonyshew](https://togithub.com/anthonyshew) in
[vercel/turbo#8689
- update env_wildcards for SvelteKit by
[@&#8203;jacksteamdev](https://togithub.com/jacksteamdev) in
[vercel/turbo#8685
- fix constant width for checkmark by
[@&#8203;dimitropoulos](https://togithub.com/dimitropoulos) in
[vercel/turbo#8702
- fix(ui): respect `--output-logs` and `outputLogs` for persisting logs
after TUI exits by
[@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in
[vercel/turbo#8612
- fix(ui): only start ui if there are tasks to run by
[@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in
[vercel/turbo#8703
- chore(ui): add tracing to all tui operations by
[@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in
[vercel/turbo#8704
- adds CLI flag for controlling tui/stream by
[@&#8203;dimitropoulos](https://togithub.com/dimitropoulos) in
[vercel/turbo#8714
- feat: allow opting out of required package manager by
[@&#8203;chris-olszewski](https://togithub.com/chris-olszewski) in
[vercel/turbo#8738
- upgrade deps to avoid conflict with next.js by
[@&#8203;sokra](https://togithub.com/sokra) in
[vercel/turbo#8750
- refactor(turborepo): derive `Opts` from `Config` by
[@&#8203;NicholasLYang](https://togithub.com/NicholasLYang) in
[vercel/turbo#8759

##### New Contributors

- [@&#8203;dimitropoulos](https://togithub.com/dimitropoulos) made their
first contribution in
[vercel/turbo#8674
- [@&#8203;pathliving](https://togithub.com/pathliving) made their first
contribution in
[vercel/turbo#8675
- [@&#8203;UNRULYEON](https://togithub.com/UNRULYEON) made their first
contribution in
[vercel/turbo#8679
- [@&#8203;LaPulgaaa](https://togithub.com/LaPulgaaa) made their first
contribution in
[vercel/turbo#8683
- [@&#8203;jacksteamdev](https://togithub.com/jacksteamdev) made their
first contribution in
[vercel/turbo#8685
- [@&#8203;ony3000](https://togithub.com/ony3000) made their first
contribution in
[vercel/turbo#8642
- [@&#8203;moolcoov](https://togithub.com/moolcoov) made their first
contribution in
[vercel/turbo#8638
- [@&#8203;pkellner](https://togithub.com/pkellner) made their first
contribution in
[vercel/turbo#8669
- [@&#8203;vinnymac](https://togithub.com/vinnymac) made their first
contribution in
[vercel/turbo#8637
- [@&#8203;torresgol10](https://togithub.com/torresgol10) made their
first contribution in
[vercel/turbo#8719
- [@&#8203;baileywickham](https://togithub.com/baileywickham) made their
first contribution in
[vercel/turbo#8692
- [@&#8203;LioRael](https://togithub.com/LioRael) made their first
contribution in
[vercel/turbo#8741
- [@&#8203;mischnic](https://togithub.com/mischnic) made their first
contribution in
[vercel/turbo#8767

**Full Changelog**:
vercel/turbo@v2.0.6...v2.0.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/inabagumi/shinju-date).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants