Support monorepo package self-references #8820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
reviewed
Jul 24, 2024
sokra
reviewed
Jul 24, 2024
sokra
reviewed
Jul 26, 2024
| fragment, | ||
| options, | ||
| ); | ||
| if !(*result.is_unresolveable().await?) { |
There was a problem hiding this comment.
Should we continue to look for other packages with the same name or should this better fail resolving here if the self reference doesn't resolve?
There was a problem hiding this comment.
I think that's an uncommon case, but https://nodejs.org/api/modules.html#all-together would continue searching. So I'm inclined to continue as well
sokra
approved these changes
Jul 26, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Closes PACK-3107 Packages importing themselves works fine for packages from npm, since they always live at `.../node_modules/foo` anyway and so the regular node_modules resolution covers self-references as well. This is not the case for (symlinked) monorepo workspaces, which this PR fixes. This essentially adds the `LOAD_PACKAGE_SELF` step from https://nodejs.org/api/modules.html#all-together .
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Closes PACK-3107 Packages importing themselves works fine for packages from npm, since they always live at `.../node_modules/foo` anyway and so the regular node_modules resolution covers self-references as well. This is not the case for (symlinked) monorepo workspaces, which this PR fixes. This essentially adds the `LOAD_PACKAGE_SELF` step from https://nodejs.org/api/modules.html#all-together .
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Closes PACK-3107 Packages importing themselves works fine for packages from npm, since they always live at `.../node_modules/foo` anyway and so the regular node_modules resolution covers self-references as well. This is not the case for (symlinked) monorepo workspaces, which this PR fixes. This essentially adds the `LOAD_PACKAGE_SELF` step from https://nodejs.org/api/modules.html#all-together .
mischnic
added a commit
to vercel/next.js
that referenced
this pull request
Aug 7, 2024
I've simplified @timneutkens's tests from #66486 The resolver fix is in vercel/turborepo#8820 Closes #66486 Related issue: #66487 --------- Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PACK-3107
Packages importing themselves works fine for packages from npm, since they always live at
.../node_modules/fooanyway and so the regular node_modules resolution covers self-references as well.This is not the case for (symlinked) monorepo workspaces, which this PR fixes. This essentially adds the
LOAD_PACKAGE_SELFstep from https://nodejs.org/api/modules.html#all-together .I think the logic is sound, should I extract this into a separate function? Or is there a better place to put this anyway?