Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example lint script not working #1869

Closed
steida opened this issue Sep 6, 2022 · 2 comments · Fixed by #2130
Closed

Example lint script not working #1869

steida opened this issue Sep 6, 2022 · 2 comments · Fixed by #2130
Labels
needs: author input

Comments

@steida
Copy link

steida commented Sep 6, 2022

What version of Turborepo are you using?

None

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Describe the Bug

"lint": "TIMING=1 eslint src/**/*.ts* --fix", does not lint files.

"lint": "TIMING=1 eslint 'src/**/*.ts*' --fix", does lint files.

https://stackoverflow.com/questions/54165756/eslint-glob-is-not-considering-all-directories-recursively

Expected Behavior

Should lint files.

To Reproduce

Just try it.
@steida
Copy link
Author

steida commented Sep 6, 2022

"lint": "TIMING=1 eslint src --ext .ts,.tsx",

This is probably the best because it's not platform specific and it's recursive.

@mehulkar
Copy link
Contributor

mehulkar commented Sep 8, 2022

Could you link to which example you're talking about?

@nathanhammond nathanhammond mentioned this issue Sep 30, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #2130 Oct 6, 2022
kodiakhq bot pushed a commit that referenced this issue Oct 6, 2022
@nathanhammond
Update examples to always quote the ESLint glob. (#2130)
519b07e 
When we run ESLint we're passing in globs. We want to send those globs directly to ESLint, not let the shell intercept them and expand them in advance.

Closes #1869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: author input
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update examples to always quote the ESLint glob. nathanhammond/turbo
2 participants
@steida @mehulkar