feat: Check the number of direct dependants while tree shaking #8473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
arlyon
reviewed
Jun 14, 2024
| N8["Items: [ItemId(4, Normal)]"]; | ||
| N9["Items: [ItemId(5, VarDeclarator(0))]"]; | ||
| N10["Items: [ItemId(6, Normal)]"]; | ||
| N11["Items: [ItemId(0, ImportBinding(0)), ItemId(9, Normal)]"]; |
arlyon
approved these changes
Jun 14, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jun 18, 2024
# Turbopack * vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> ### What? Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) ### Why? I improved the performance of the parser by margin.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…l/turborepo#8473) ### Description <img width="285" alt="image" src="https://github.com/vercel/turbo/assets/29931815/c37d81fb-ab6e-482a-8e6f-3784a62e923b"> In the graph above, `x` and `y` can both reach `item 5`, but grouping from `item 5` to `item 9` is fine
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…l/turborepo#8473) ### Description <img width="285" alt="image" src="https://github.com/vercel/turbo/assets/29931815/c37d81fb-ab6e-482a-8e6f-3784a62e923b"> In the graph above, `x` and `y` can both reach `item 5`, but grouping from `item 5` to `item 9` is fine
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…l/turborepo#8473) ### Description <img width="285" alt="image" src="https://github.com/vercel/turbo/assets/29931815/c37d81fb-ab6e-482a-8e6f-3784a62e923b"> In the graph above, `x` and `y` can both reach `item 5`, but grouping from `item 5` to `item 9` is fine
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…l/turborepo#8473) ### Description <img width="285" alt="image" src="https://github.com/vercel/turbo/assets/29931815/c37d81fb-ab6e-482a-8e6f-3784a62e923b"> In the graph above, `x` and `y` can both reach `item 5`, but grouping from `item 5` to `item 9` is fine
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) I improved the performance of the parser by margin.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) I improved the performance of the parser by margin.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
# Turbopack * vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> ### What? Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) ### Why? I improved the performance of the parser by margin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the graph above,
xandycan both reachitem 5, but grouping fromitem 5toitem 9is fineTesting Instructions