Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle.writeLatin1String is not a function on Node 6.5 #23

Closed
leo opened this issue Sep 10, 2016 · 4 comments
Closed

handle.writeLatin1String is not a function on Node 6.5 #23

leo opened this issue Sep 10, 2016 · 4 comments

Comments

@leo
Copy link
Contributor

leo commented Sep 10, 2016

Works fine on earlier versions of 6.x.

net.js:732
      return handle.writeLatin1String(req, data);
                    ^

TypeError: handle.writeLatin1String is not a function
    at createWriteReq (net.js:732:21)
    at Socket._writeGeneric (net.js:702:11)
    at Socket._write (net.js:725:8)
    at doWrite (_stream_writable.js:307:12)
    at clearBuffer (_stream_writable.js:414:7)
    at Socket.Writable.uncork (_stream_writable.js:243:7)
    at ClientRequest._flushOutput (_http_outgoing.js:666:10)
    at ClientRequest.OutgoingMessage._flush (_http_outgoing.js:640:16)
    at _http_client.js:195:10
    at callSocketMethod (_http_client.js:591:7)

@quarterto

@leo leo added the patch label Sep 10, 2016
@rauchg
Copy link
Member

rauchg commented Sep 12, 2016

@leo pretty sure I fixed this issue. @quarterto can you confirm?

@apaleslimghost
Copy link

Sorry @rauchg, still seeing this issue with now 0.25

@apaleslimghost
Copy link

@rauchg seems to be fixed with 0.25.1 and above, thanks!

@leo
Copy link
Contributor Author

leo commented Oct 24, 2016

Yey!

@leo leo closed this as completed Oct 24, 2016
TooTallNate pushed a commit that referenced this issue Aug 23, 2019
TooTallNate pushed a commit that referenced this issue Aug 23, 2019
* Add tests for libraries breaking on now/node

* Fix eslint errors

* Change order of extends
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants