[cli] Add client.fetchPaginated() async iterator
#10054
Conversation
Adds async iterator helper function for interacting with endpoints that have pagination. Implemented for use with `vc bisect` (fetching deployments) and `vc link --repo` (fetching projects).
TooTallNate
requested review from
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
🦋 Changeset detectedLatest commit: 323f21e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
internals/types/index.d.ts
Outdated
| @@ -383,7 +383,7 @@ export interface ProjectLink { | |||
| export interface PaginationOptions { | |||
| prev: number; | |||
| count: number; | |||
| next?: number; | |||
| next?: number | null; | |||
There was a problem hiding this comment.
question (non-blocking): Is there some type shuffling we can do to make this not both null and undefined?
There was a problem hiding this comment.
From what I've seen so far I think the API will always return null. Will double check on that though.
There was a problem hiding this comment.
We could wrap it to get rid of one of the types. It's not a huge deal, but I do like simplifying these when they come up. I don't want to read the type later and wonder what the difference between undefined and null means for this property.
There was a problem hiding this comment.
Updated to use the same type as defined in API repo
TooTallNate
dismissed stale reviews from cb1kenobi and EndangeredMassa
via
166ae0c
Adds async iterator helper function for interacting with endpoints that have pagination.
Implemented for use with
vc bisect(fetching deployments) andvc link --repo(fetching projects).