Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] vc env pull should add .env*.local to .gitignore #10085

Merged
merged 3 commits into from Jun 8, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 7, 2023

This is a follow up to PR #9892 which changed the default to .env.local.

Now that we know local files should never be committed to git, we can automatically add .env*.local to .gitignore. Note that this is the same ignore pattern that ships with create-next-app as seen here, so most Next.js users won't see anything change.

See the related Linear ticket

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: fee8c02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@styfle styfle marked this pull request as ready for review June 7, 2023 23:15
@styfle styfle added area: cli semver: patch PR contains bug fixes pr: automerge Automatically merge the PR when checks pass labels Jun 7, 2023
@styfle styfle requested a review from TooTallNate June 7, 2023 23:38
@kodiakhq kodiakhq bot merged commit fecebfa into main Jun 8, 2023
103 checks passed
@kodiakhq kodiakhq bot deleted the fix-env-local-add-git-ignore branch June 8, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli pr: automerge Automatically merge the PR when checks pass semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants