[cli] Change vc env pull default output file to .env.local
#9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-stowell
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
styfle
reviewed
May 2, 2023
styfle
changed the title
pull write to .env.localvc env pull default to .env.local
styfle
reviewed
May 2, 2023
|
@styfle does |
|
@dan-stowell Yes this is semver-major because its a breaking change (needs the label too) |
cb1kenobi
previously approved these changes
May 3, 2023
EndangeredMassa
previously requested changes
May 3, 2023
There was a problem hiding this comment.
Should we update these references to .env as well?
- errors/missing-env-file.md - should refer to
.env.local? - examples/sanity/.env.template - should be
.env.local.template? - packages/cli/src/util/dev/server.ts - line 674 and 675 should use
.env.localand maybe fall back to.env? - packages/cli/src/util/dev/types.ts - comments in
EnvConfigsshould refer to.env.local
I'm not positive how best to update dev/server.ts, but I think we should take a stab at them in this PR.
…d" test" This reverts commit 3c43a9e.
Done & pushed.
Done & pushed.
Based on discussion in Linear, it seems that we do not want |
dan-stowell
dismissed
EndangeredMassa’s stale review
Let's make vc dev changes separately.
styfle
previously approved these changes
May 4, 2023
EndangeredMassa
previously approved these changes
May 5, 2023
cb1kenobi
added
pr: automerge
TooTallNate
changed the title
vc env pull default to .env.localvc env pull default output file to .env.local
TooTallNate
dismissed stale reviews from styfle, cb1kenobi, and EndangeredMassa
via
c33be8c
🦋 Changeset detectedLatest commit: c33be8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
styfle
approved these changes
May 22, 2023
cb1kenobi
approved these changes
May 22, 2023
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
This is a follow up to PR #9892 which changed the default to `.env.local`. Now that we know local files should never be committed to git, we can automatically add `.env*.local` to `.gitignore`. Note that this is the same ignore pattern that ships with create-next-app [as seen here](https://github.com/vercel/next.js/blob/06abd634899095b6cc28e6e8315b1e8b9c8df939/packages/create-next-app/templates/app/js/gitignore#L28), so most Next.js users won't see anything change. See the related [Linear ticket](https://linear.app/vercel/issue/VCCLI-461/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vc deployignores.env.local. To make sure we don't inadvertently push people's secrets to source control, have all environment pulls default to writing to.env.local.Linear ticket