Properly error on wrong token and handle team #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
reviewed
Jan 14, 2018
|
|
||
| // Don't use team from config if `--token` was set | ||
| if (ctx.config.sh && ctx.config.sh.currentTeam) { | ||
| delete ctx.config.sh.currentTeam |
There was a problem hiding this comment.
Not a fan of changing the source of truth. I think that should be handled by the consumer of this function.
|
Thanks @leo sounds like exactly what I noticed earlier this week 👌 |
leo
added a commit
that referenced
this pull request
Jan 14, 2018
* Properly error on wrong token and handle team * Better wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we're not using the team from the config if
--tokenwas passed. In addition, a invalid token now leads to a proper error.This closes #1072.