Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] add test for multiple cookies on edge #10746

Closed
wants to merge 2 commits into from

Conversation

dstaley
Copy link

@dstaley dstaley commented Oct 22, 2023

This PR adds a test case demonstrating the ability to set multiple cookies in an edge runtime API handler.

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2023

⚠️ No Changeset found

Latest commit: a92d646

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dstaley
Copy link
Author

dstaley commented Nov 2, 2023

I believe this will be fixed in the next release of edge-runtime, which should contain this PR which fixed set-cookie header parsing.

@Ethan-Arrowood
Copy link
Contributor

Have you seen #10767 yet? This might have some impact to your work.

@Kikobeats
Copy link
Member

the test is passing green to me :thinkies:

CleanShot 2023-11-03 at 10 04 12@2x

@dstaley
Copy link
Author

dstaley commented Nov 3, 2023

@Kikobeats you skipped the test this PR adds :) It's named allow setting multiple cookies with same name on edge runtime

@dstaley dstaley changed the title [node] add failing test for multiple cookies on edge [node] add test for multiple cookies on edge Nov 7, 2023
@dstaley
Copy link
Author

dstaley commented Nov 7, 2023

With the changes from #10712, this test case is now passing.

@vercel/node:test-unit:   ✓ allow setting multiple cookies with same name (2834 ms)
@vercel/node:test-unit:   ✓ allow setting multiple cookies with same name on edge runtime (2832 ms)

Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍

@EndangeredMassa
Copy link
Contributor

We test this in a different way here: https://github.com/vercel/vercel/blob/main/packages/node/test/dev-fixtures/multiple-cookies.ts

Maybe we should do both? Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants