-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] Ensure all static routes have static streaming lambda path #11259
Merged
wyattjoh
merged 2 commits into
main
from
wyattjohnson/next-2210-rewrites-not-working-as-expected
Mar 14, 2024
Merged
[next] Ensure all static routes have static streaming lambda path #11259
wyattjoh
merged 2 commits into
main
from
wyattjohnson/next-2210-rewrites-not-working-as-expected
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 163d151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a35c6b2
to
d1c1921
Compare
d1c1921
to
b4854a5
Compare
b4854a5
to
923399c
Compare
ijjk
approved these changes
Mar 14, 2024
923399c
to
163d151
Compare
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Mar 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@7.9.1 ### Patch Changes - Export `getSupportedNodeVersion` ([#11277](#11277)) ## vercel@33.6.1 ### Patch Changes - Don't send `projectSettings.nodeVersion` for unsupported versions ([#11277](#11277)) - Updated dependencies \[[`4bca0c6d0`](4bca0c6), [`a67ad4b5a`](a67ad4b), [`11218a179`](11218a1), [`64b97bf4b`](64b97bf)]: - @vercel/next@4.1.6 - @vercel/remix-builder@2.1.4 - @vercel/build-utils@7.9.1 - @vercel/static-build@2.4.4 - @vercel/node@3.0.24 ## @vercel/client@13.1.7 ### Patch Changes - Updated dependencies \[[`11218a179`](11218a1)]: - @vercel/build-utils@7.9.1 ## @vercel/gatsby-plugin-vercel-builder@2.0.22 ### Patch Changes - Updated dependencies \[[`11218a179`](11218a1)]: - @vercel/build-utils@7.9.1 ## @vercel/next@4.1.6 ### Patch Changes - Ensure that static PPR pages have static streaming lambda paths. ([#11259](#11259)) ## @vercel/node@3.0.24 ### Patch Changes - Updated dependencies \[[`11218a179`](11218a1)]: - @vercel/build-utils@7.9.1 ## @vercel/remix-builder@2.1.4 ### Patch Changes - Disable `prepareCache()` npm install for Remix + Vite ([#11281](#11281)) ## @vercel/static-build@2.4.4 ### Patch Changes - [framework-fixtures]: Bump the core group in /packages/static-build/test/fixtures/angular-v17 with 15 updates ([#11274](#11274)) - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.22 ## @vercel-internals/types@1.0.27 ### Patch Changes - Updated dependencies \[[`11218a179`](11218a1)]: - @vercel/build-utils@7.9.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's a match for a prerender, the dynamic query parameters will not be provided via the
x-now-route-matches
. This ensures that when generating any static route that the static streaming lambda path is used if it's provided, ensuring that when a page is generated viagenerateStaticParams
:That we use the specific routes (
/blog/one
,/blog/two
, and/blog/three
) for the partial prerendering streaming path instead of the paramatarized pathname (/blog/[slug]
) as the rewrites won't be matched once a match for a prerender has been found.This additionally updates the tests to ensure that the correct pathname is observed (this was previously silently failing).