Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Enforce node18 on Python and Ruby examples #11319

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[examples] Enforce node18 on Python and Ruby examples #11319

merged 2 commits into from
Mar 25, 2024

Conversation

ofhouse
Copy link
Member

@ofhouse ofhouse commented Mar 22, 2024 •
edited

We have to enforce the node version on some examples to make sure they are not auto upgraded in the future before we support their runtime.

See https://vercel.com/docs/deployments/build-image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2024 •
edited

⚠️ No Changeset found

Latest commit: 3da33fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ofhouse ofhouse changed the title [examples] Enforce node18 [examples] Enforce node18 on Python and Ruby examples Mar 22, 2024
janory
janory approved these changes Mar 22, 2024
View reviewed changes
Copy link

@janory janory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ofhouse ofhouse merged commit 7054532 into main Mar 25, 2024
113 of 114 checks passed
@ofhouse ofhouse deleted the ofhouse/examples-enforce-node-18 branch March 25, 2024 10:15
janory added a commit that referenced this pull request May 6, 2024
@janory
Revert "[examples] Enforce node18 on Python and Ruby examples (#11319)"
ec4a78b 
This reverts commit 7054532.
@janory janory mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@janory janory janory approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@trek trek Awaiting requested review from trek trek is a code owner

@onsclom onsclom Awaiting requested review from onsclom onsclom is a code owner

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55 jeffsee55 is a code owner

@leerob leerob Awaiting requested review from leerob leerob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofhouse @TooTallNate @janory