Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM 1720 Added sunset warning to the secrets command #11333

Conversation

marcgreenstock
Copy link
Contributor

This PR adds a warning to the secrets command that the command will be sunset on 1st May.

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 92517de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

trek
trek previously approved these changes Mar 26, 2024
Copy link
Contributor

@EndangeredMassa EndangeredMassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

)} command will be deprecated at this time, please use the ${getCommandName(
'env'
)} command instead.\n` +
'See https://vercel.com/changelog/legacy-environment-variable-secrets-are-being-sunset for more information.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (soft-blocking): use vercel.link

In this or a follow-up PR: Can we change this out for a vercel.link that points there instead? We typically use these from Vercel CLI messages for tracking and optional redirecting later. (Examples)


For reference: The vercel.link URLs are managed in bit.ly via Okta.‏

@EndangeredMassa EndangeredMassa added the pr: automerge Automatically merge the PR when checks pass label Mar 27, 2024
@EndangeredMassa
Copy link
Contributor

Added automerge so that this should get in after we fix the CI issues in: #11329

@kodiakhq kodiakhq bot merged commit 49f8897 into main Mar 28, 2024
7 of 8 checks passed
@kodiakhq kodiakhq bot deleted the marcgreenstock/iam-1720-change-secrets-commands-note-to-warning-and-mention-the-2024 branch March 28, 2024 08:13
EndangeredMassa pushed a commit that referenced this pull request Mar 28, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/build-utils@7.10.0

### Minor Changes

- Allow environment variables to be specified for `EdgeFunction`
([#11029](#11029))

## vercel@33.6.2

### Patch Changes

- Added sunset warning to secrets command.
([#11333](#11333))

- Swap jest for vitest in CLI unit tests
([#11302](#11302))

- Updated dependencies
\[[`988f7b75a`](988f7b7),
[`1825b58df`](1825b58)]:
    -   @vercel/remix-builder@2.1.5
    -   @vercel/build-utils@7.10.0
    -   @vercel/node@3.0.25
    -   @vercel/static-build@2.4.5

## @vercel/client@13.1.8

### Patch Changes

- Updated dependencies
\[[`1825b58df`](1825b58)]:
    -   @vercel/build-utils@7.10.0

## @vercel/frameworks@3.0.1

### Patch Changes

- Swap jest for vitest in CLI unit tests
([#11302](#11302))

## @vercel/fs-detectors@5.2.2

### Patch Changes

- Updated dependencies
\[[`9ed967034`](9ed9670)]:
    -   @vercel/frameworks@3.0.1

## @vercel/gatsby-plugin-vercel-builder@2.0.23

### Patch Changes

- Updated dependencies
\[[`1825b58df`](1825b58)]:
    -   @vercel/build-utils@7.10.0

## @vercel/node@3.0.25

### Patch Changes

- Updated dependencies
\[[`1825b58df`](1825b58)]:
    -   @vercel/build-utils@7.10.0

## @vercel/remix-builder@2.1.5

### Patch Changes

- Add `mjs` and `mts` extensions to vite detection
([#11307](#11307))

## @vercel/static-build@2.4.5

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/gatsby-plugin-vercel-builder@2.0.23

## @vercel-internals/types@1.0.28

### Patch Changes

- Updated dependencies
\[[`1825b58df`](1825b58)]:
    -   @vercel/build-utils@7.10.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants