[client] Always use v13 of create deployment API endpoint

.changeset/famous-apples-unite.md

@@ -0,0 +1,5 @@
+---
+'vercel': patch
+---
+
+Always set `projectSettings.nodeVersion` in `vc deploy`

.changeset/small-ghosts-kiss.md

@@ -0,0 +1,5 @@
+---
+'@vercel/client': minor
+---
+
+Always use v13 of create deployment API endpoint

packages/cli/src/commands/deploy/index.ts

@@ -520,23 +520,6 @@ export default async (client: Client): Promise<number> => {
     );
   }
 
-  const { packageJson } = await scanParentDirs(
-    join(cwd, project?.rootDirectory ?? ''),
-    true,
-    cwd
-  );
-  let nodeVersion: string | undefined;
-  if (packageJson?.engines?.node) {
-    try {
-      const { range } = await getSupportedNodeVersion(packageJson.engines.node);
-      nodeVersion = range;
-    } catch (error) {
-      if (error instanceof Error) {
-        output.warn(error.message);
-      }
-    }
-  }
-
   try {
     // if this flag is not set, use `undefined` to allow the project setting to be used
     const autoAssignCustomDomains = argv['--skip-domain'] ? false : undefined;
@@ -573,7 +556,6 @@ export default async (client: Client): Promise<number> => {
       createArgs.projectSettings = {
         sourceFilesOutsideRootDirectory,
         rootDirectory,
-        nodeVersion,
       };
 
       if (status === 'linked') {
@@ -584,6 +566,30 @@ export default async (client: Client): Promise<number> => {
       }
     }
 
+    // Read the `engines.node` field from `package.json` and send as a
+    // `projectSettings` property as an optimization (so that the API
+    // does not need to retrieve the file to do this check).
+    const { packageJson } = await scanParentDirs(
+      join(cwd, project?.rootDirectory ?? ''),
+      true,
+      cwd
+    );
+    let nodeVersion: string | undefined;
+    if (packageJson?.engines?.node) {
+      try {
+        const { range } = await getSupportedNodeVersion(
+          packageJson.engines.node
+        );
+        nodeVersion = range;
+      } catch (error) {
+        if (error instanceof Error) {
+          output.warn(error.message);
+        }
+      }
+    }
+    if (!createArgs.projectSettings) createArgs.projectSettings = {};
+    createArgs.projectSettings.nodeVersion = nodeVersion;
+
     deployment = await createDeploy(
       client,
       now,

packages/cli/test/fixtures/unit/commands/deploy/legacy-builds/.vercel/project.json

@@ -0,0 +1,4 @@
+{
+  "orgId": "team_dummy",
+  "projectId": "legacy-builds"
+}

packages/cli/test/fixtures/unit/commands/deploy/legacy-builds/index.js

@@ -0,0 +1 @@
+module.exports = (req, res) => res.end('Vercel');

packages/cli/test/fixtures/unit/commands/deploy/legacy-builds/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "node",
+  "version": "1.0.0",
+  "private": true,
+  "engines": {
+    "node": "18.x"
+  }
+}

packages/cli/test/fixtures/unit/commands/deploy/legacy-builds/vercel.json

@@ -0,0 +1,5 @@
+{
+  "builds": [
+    { "src": "index.js", "use": "@vercel/node" }
+  ]
+}

packages/cli/test/unit/commands/deploy.test.ts

@@ -466,6 +466,54 @@ describe('deploy', () => {
     });
   });
 
+  it('should send `projectSettings.nodeVersion` based on `engines.node` package.json field with `builds` in `vercel.json`', async () => {
+    const user = useUser();
+    useTeams('team_dummy');
+    useProject({
+      ...defaultProject,
+      name: 'legacy-builds',
+      id: 'QmbKpqpiUqbcke',
+    });
+
+    let body: any;
+    client.scenario.post(`/v13/deployments`, (req, res) => {
+      body = req.body;
+      res.json({
+        creator: {
+          uid: user.id,
+          username: user.username,
+        },
+        id: 'dpl_',
+      });
+    });
+    client.scenario.get(`/v13/deployments/dpl_`, (req, res) => {
+      res.json({
+        creator: {
+          uid: user.id,
+          username: user.username,
+        },
+        id: 'dpl_',
+        readyState: 'READY',
+        aliasAssigned: true,
+        alias: [],
+      });
+    });
+
+    const repoRoot = setupUnitFixture('commands/deploy/legacy-builds');
+    client.cwd = repoRoot;
+    client.setArgv('deploy');
+    const exitCode = await deploy(client);
+    expect(exitCode).toEqual(0);
+    expect(body).toMatchObject({
+      source: 'cli',
+      version: 2,
+      projectSettings: {
+        nodeVersion: '18.x',
+        sourceFilesOutsideRootDirectory: true,
+      },
+    });
+  });
+
   it('should send latest supported node version when given a >low-node-version based on `engines.node` package.json field', async () => {
     const user = useUser();
     useTeams('team_dummy');

packages/client/src/check-deployment-status.ts

@@ -31,10 +31,7 @@ export async function* checkDeploymentStatus(
 
   let deploymentState = deployment;
 
-  const apiDeployments = getApiDeploymentsUrl({
-    builds: deployment.builds,
-    functions: deployment.functions,
-  });
+  const apiDeployments = getApiDeploymentsUrl();
 
   // If the deployment is ready, we don't want any of this to run
   if (isDone(deploymentState) && isAliasAssigned(deploymentState)) {

packages/client/src/deploy.ts

@@ -27,7 +27,11 @@ async function* postDeployment(
 }> {
   const debug = createDebug(clientOptions.debug);
   const preparedFiles = prepareFiles(files, clientOptions);
-  const apiDeployments = getApiDeploymentsUrl(deploymentOptions);
+  const apiDeployments = getApiDeploymentsUrl();
+
+  if (deploymentOptions?.builds && !deploymentOptions.functions) {
+    clientOptions.skipAutoDetectionConfirmation = true;
+  }
 
   debug('Sending deployment creation API request');
   try {

packages/client/src/utils/index.ts

@@ -6,7 +6,7 @@ import { URL } from 'url';
 import ignore from 'ignore';
 import { pkgVersion } from '../pkg';
 import { NowBuildError } from '@vercel/build-utils';
-import { VercelClientOptions, DeploymentOptions, VercelConfig } from '../types';
+import { VercelClientOptions, VercelConfig } from '../types';
 import { Sema } from 'async-sema';
 import { readFile } from 'fs-extra';
 import readdir from './readdir-recursive';
@@ -46,13 +46,7 @@ const EVENTS_ARRAY = [
 export type DeploymentEventType = typeof EVENTS_ARRAY[number];
 export const EVENTS = new Set(EVENTS_ARRAY);
 
-export function getApiDeploymentsUrl(
-  metadata?: Pick<DeploymentOptions, 'builds' | 'functions'>
-) {
-  if (metadata && metadata.builds && !metadata.functions) {
-    return '/v10/deployments';
-  }
-
+export function getApiDeploymentsUrl() {
   return '/v13/deployments';
 }