[client] Always use v13 of create deployment API endpoint #11351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56af103 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TooTallNate
requested review from
EndangeredMassa,
trek,
onsclom,
jeffsee55 and
erikareads
as code owners
EndangeredMassa
approved these changes
Apr 10, 2024
Comment on lines
+585
to
+587
| if (error instanceof Error) { | ||
| output.warn(error.message); | ||
| } |
There was a problem hiding this comment.
suggestion (soft-blocking): log other values
If for some reason this variable isn't an instance of Error, we should still log it.
Suggested change
| if (error instanceof Error) { | |
| output.warn(error.message); | |
| } | |
| if (error instanceof Error) { | |
| output.warn(error.message); | |
| } else { | |
| output.warn(error.toString()); | |
| } |
Merged
TooTallNate
added a commit
that referenced
this pull request
Apr 10, 2024
Updates `@vercel/client` to always use the v13 create-deployment endpoint, even when `builds` is present. This allows for `projectSettings.nodeVersion` to be passed when `builds` is present.
EndangeredMassa
pushed a commit
that referenced
this pull request
Apr 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.0.0 ### Major Changes - Disables promotion of preview deployments ([#11411](#11411)) ### Patch Changes - Always set `projectSettings.nodeVersion` in `vc deploy` ([#11351](#11351)) - [cli] optional override of existing environment variables with --force ([#11348](#11348)) ## @vercel/client@13.2.0 ### Minor Changes - Always use v13 of create deployment API endpoint ([#11351](#11351)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
@vercel/clientto always use the v13 create-deployment endpoint, even whenbuildsis present. This allows forprojectSettings.nodeVersionto be passed whenbuildsis present.